Ticket #8317 (closed: fixed)
[ICAT] run range issues
Reported by: | Jay Rainey | Owned by: | Jay Rainey |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.0 |
Component: | GUI | Keywords: | ICAT |
Cc: | Blocked By: | ||
Blocking: | Tester: | Nick Draper |
Description
If you only fill in one side of the run-range an error is thrown: bad lexical cast: source type value could not be interpreted as target. Moreover, the size of the run range is 5-5 (e.g. 00000-00000), which is too small.
The following needs fixed:
- No error if user inputs only one side (assume from start (000000) to INPUT, or INPUT to end (perhaps +10k?)
- Remove limit on run-range size.
Change History
comment:2 Changed 7 years ago by Jay Rainey
- Status changed from new to verify
- Resolution set to fixed
comment:3 Changed 7 years ago by Martyn Gigg
- Status changed from verify to reopened
- Resolution fixed deleted
The functionality now works as described but the run range box is a little clunky and hard to use. I think we need to simplify it so that users can enter their text and we then parse what is there to decide whether it is a range, accepting either : or - as a separators.
If there is no separator then simply put the same number as start/end.
comment:4 Changed 7 years ago by Jay Rainey
- Status changed from reopened to inprogress
Improved run-range parse logic. Refs #8317.
- Added tooltip and removed input mask from run-range field.
Changeset: d9b068ca40abfaee396ec2f1d169504d8b2b7772
comment:5 Changed 7 years ago by Jay Rainey
Added validator to run-range. Refs #8317.
- This allows only numbers and one hyphen or colon.
Changeset: d42538cb2ffa4767a4d66e58c48f9b90a2a520d2
comment:6 Changed 7 years ago by Jay Rainey
- Status changed from inprogress to verify
- Resolution set to fixed
I have fixed this ticket, and you can find the changes here and the branch on github here.
To test