Ticket #8324 (closed)

Opened 7 years ago

Last modified 5 years ago

Add ISIS event instruments to facilities.xml

Reported by: Nick Draper Owned by: Nick Draper
Priority: critical Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

add event duplicates to the facilities.xml to allow event or histogram based live data collection for the event instruments at ISIS.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to inprogress

re #8324 add _EVENT instruments to ISIS facilites.xml

Changeset: c3ad42e85243d978fa5cba0085515279fa4e8176

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  1. There are no live DAE's to connect to so you cannot test that this works.
  2. You can however test that this fails nicely.
  3. StartLiveData
  4. Pick an _Event instrument
  5. Start the listener
  6. It should timeout with a reasonable message after a few seconds.
  7. The path to connect in the error message should be ndxInstrument:10000

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from reopened to inprogress

re #8324 make unit test more flexible to the number of intruments

Changeset: f7f1572a3190dc31be6be98b641ad8fdd589eb76

comment:5 Changed 7 years ago by Nick Draper

re #8324 make unit test more flexible to the number of diffractometers

Changeset: 713b878c57dedf255568b6713379210302572325

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 7 years ago by Russell Taylor

  • Status changed from verify to reopened
  • Resolution fixed deleted

This has broken the system test that validates the Facilities file. However, it's the schema that's wrong - it hasn't accounted for the valid possibility of overriding the facility default listener for a particular instrument. I'll fix it up.

comment:8 Changed 7 years ago by Russell Taylor

  • Status changed from reopened to inprogress

Re #8324. Add an optional listener attribute to the livedata element.

This accounts for the valid possibility that a particular instrument uses a different live listener to the facility default.

Changeset: ca14595a3f542db4ce050d01aad6e7fa49588242

comment:9 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to closed
  • Resolution set to fixed

System test is now passing again.

comment:10 Changed 7 years ago by Russell Taylor

  • Status changed from closed to verify
  • Resolution fixed deleted

comment:11 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:12 Changed 7 years ago by Martyn Gigg

System tests are now passing, the expected instruments are listed in the StartLiveData interface and the errors are reported as expected.

comment:13 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8324_Event_instruments_in_Facilities'

Full changeset: ​b2880c50cd5adf4d4479cc7395358dc4705de933

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9169

Note: See TracTickets for help on using tickets.