Ticket #8325 (closed: fixed)
LoadLogs isn't loading 3 column log files.
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description (last modified by Samuel Jackson) (diff)
LoadLog doesn't appear to be working for 3 column files. It appears to simply append the entire log file as a single string entry.
Change History
comment:2 Changed 7 years ago by Samuel Jackson
- Status changed from new to inprogress
Refs #8325 Fixed bug in LoadLogs.
Swapped to using first line as indicator of file type. Removed outdated failing tests for RemoveLogs.
Changeset: 2649ad7876b4fe870a789e43c7f89c4ce24da4f6
comment:3 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
Logs for raw files were not being loaded correctly for the IRIS instrument when using the LoadLogs algorithm. This was due to one of the logs (Cryovalve) having no value causing the algorithm to incorrectly use the wrong loading routine.
We've swapped the algorithm to check the first line of each file as an indication of the whether the file is two or three columns and when reading three column logs and finding an entry with only two values the algorithm should now just skip it.
This change should only affect ISIS log loading and in no way affect SNS.
To Tester
Use some of the raw files generated by IRIS from the most recent cycle and attempt to load them. Logs present in the .log file will not be loaded. The fix in this ticket should correct this.
comment:5 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:7 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/8325_load_log_bug'
Full changeset: 9b3ac49dec1166d6f113a4d00c01f5927d6f019c
