Live Data: End of run 'rename' option does not reliably work

[Russell Taylor]

MonitorLiveData tries to get the run number out of the final workspace (at line 183-5) by calling ExperimentInfo::getRunNumber (which looks for it in the logs). However, this will fail if that workspace is not a MatrixWorkspace (e.g. a Table or and MD workspace), as well as if whatever analysis has been run has not propagated the logs right through.

This then means that at the final workspace from the run will just get a suffix of 0 instead of the actual run number. This is a particular problem when trying to build up a view of multiple runs - e.g. in the VSI.

Probably, the proper fix is to get the run number into the ILiveListener interface. As a quick(er) & dirty fix though I think the thing to do is to try and get it from the 'chunk' workspace as soon as extractData() has been called (this is in LoadLiveData).

[Russell Taylor]

Re #8326. Get the run number from the unprocessed workspace.

This tries to extract the run number from the workspace returned by ILiveListener::extractData() instead of the final workspace that results from whatever workflow the user specifies. In the latter case, the run number may not be available because the workspace is not of the assumed type, or it may not have been passed right through the analysis. This way improves our odds. It would still fail if, e.g., a WorkspaceGroup is passed back.

Probably a better implementation for later would be for this to be available in the ILiveListener interface.

Changeset: a8a3f844c9ecf5ecfa7c8395f8f8011bb80f45f8

[Russell Taylor]

Re #8326. exec was public for a reason.

Changeset: 9b428efa29bc8deb2699bc7a115a80622f8af0a8

[Russell Taylor]

Re #8326. Add some testing.

Changeset: 5ad85958509a3c960a3406637e5a88073fab6a0f

[Russell Taylor]

Waiting for Michael to check that this works for the workflow with which he first encountered the problem.

[Russell Taylor]

Michael to test - he knows how to do so.

[Michael Reuter]

Merge remote-tracking branch 'origin/bugfix/8326_live_run_number'

Full changeset: ​24566bfe9e2e54c4c02f4946e872475888cfb0d8

[Russell Taylor]

#8342 has been created to look at moving this into the ILiveListener interface.

[Stuart Campbell]

This ticket has been transferred to github issue ​9171