Ticket #8330 (closed: fixed)
Fix ICP Event log entries
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
Look at a recent run like WISH00026110. The ICP event logs have two entries that are unknown to us. These are START_COLLECTION and STOP_COLLECTION. These are important events that we ought to take account of the same way that we do for BEGIN and END.
Change History
comment:2 Changed 7 years ago by Owen Arnold
refs #8330. Fix unknown ICP entry issue.
Add two additional ICP conditions.
Changeset: 069f60c198ec48730a2cc944dd1acfddc4bc6402
comment:3 Changed 7 years ago by Owen Arnold
Revert "refs #8330. Fix unknown ICP entry issue."
This reverts commit 069f60c198ec48730a2cc944dd1acfddc4bc6402.
Changeset: ffdc611a839433233c3086ba8d8e267631bf5df2
comment:4 Changed 7 years ago by Owen Arnold
Look at LOQ49886.nxs. This seems to have Start and Stop collections corresponding to periods. Do we need to take this into account?
- Open this file (its in AutoTests)
- Open logs
- Look at icp_event logs.
- Have period numbers against start collect and stop collect.
comment:5 Changed 7 years ago by Nick Draper
I've had a chat with Roman.
- He can't remember ever seeing thosse start and end collection records either, so they must be new (I'll follow up with Freddie).
- Our filtering for periods uses the change period command
- I think for this release we just go ahead with the plan of adding start and end collection to the filters, and I'll raise a ticket for the next release to re-organise this.
comment:6 Changed 7 years ago by Nick Draper
- Blocking 8334 removed
Ticket #8334 created for follow on work
comment:8 Changed 7 years ago by Owen Arnold
Revert "Revert "refs #8330. Fix unknown ICP entry issue.""
This reverts commit ffdc611a839433233c3086ba8d8e267631bf5df2.
Changeset: f947fc3b867a9291bc7c70c29604c2c3d5cc51c8
comment:9 Changed 7 years ago by Owen Arnold
refs #8330. Fix failing test.
Inspect the ICP event log for this workspace to see why the number needed changing.
Changeset: 0296fce118d1811367767b2e73978cf1dc9a5cd6
comment:10 Changed 7 years ago by Owen Arnold
refs #8330. Fix warning.
Changeset: 34e88359936f02d193d0d1f9f5f6db2c10f51992
comment:11 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
Tester. The unit tests should provide a good guide to how this is working now. I would advise a system test run too if possible.
comment:12 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:13 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8330_icp_events'
Full changeset: 2e63753977a2c827e8b498f5d22a7e43eb60fe21
comment:14 Changed 7 years ago by Nick Draper
tested by code review and unit tests passing
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9175
