Ticket #8333 (closed: fixed)
Improve getting the instrument name and run number in IndirectCommon.py
| Reported by: | Roman Tolchenov | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Roman Tolchenov |
Description
The code shouldn't use naming conventions for extracting the instrument name and the run number if there are better ways of doing it.
See getInstrRun() and getWSprefix() functions in IndirectCommon.py
Change History
comment:4 Changed 7 years ago by Samuel Jackson
- Status changed from assigned to inprogress
Refs #8333 Replace regex code with proper Mantid API calls.
Changeset: 2cb42ed0364483e0b606fd64787c0c3dc3539292
comment:5 Changed 7 years ago by Samuel Jackson
Refs #8333 Remove parsing string names from IDA code.
Instead of parsing a string based of the file name, we should just use the workspace.
Changeset: c5c493cac7e4fbed6bbaff2a061f3d172c307d31
comment:6 Changed 7 years ago by Samuel Jackson
Refs #8333 Use the instrument file prefix for the run name.
Changeset: 74e7a26012c3936f92e73ca9e0a4f89b3a9f9f5e
comment:7 Changed 7 years ago by Samuel Jackson
Refs #8333 Correct log file search issue in ElWin.
ElWin attempts to search for a log file if it hasn't been loaded already. These modifications let it correctly search for what the log file should be called.
Changeset: 569cba04b329d6346cf8e0c8f630360c6d8408b4
comment:8 Changed 7 years ago by Samuel Jackson
Refs #8333 Fixes for system tests.
Changeset: 8d969de1e4a63096effba7ac3e5d24602a495fff
comment:9 Changed 7 years ago by Samuel Jackson
Refs #8333 Remove debugging statement.
Changeset: 2464c2b04d8a9db653c8c1eea0fdd913e4dc2cba
comment:10 Changed 7 years ago by Samuel Jackson
Merge branch 'feature/8333_indirect_inst_name_and_run' into develop
Refs #8333
Conflicts:
Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py
Changeset: ae198ebb7504eb0d808d099cbe03b7177e5dcb1c
comment:11 Changed 7 years ago by Samuel Jackson
Refs #8333 Fall back on parsing the name if no run number found.
Changeset: d469b29ad0de51ffbe3e12ba21f08b6dd1a0a0df
comment:12 Changed 7 years ago by Samuel Jackson
Refs #8333 Fix name of system test workspace.
Changeset: 65bfa59f75710a9ea5f8fd8a5187f1bc384e0b31
comment:13 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Tester
These changes affect just about every interface in ISIS Indirect. Firstly, check that the system tests are passing. You may try running some of the interfaces if you like to ensure they are still working, although it might take you a while to run all of them. Instructions for doing that can be found at:
http://www.mantidproject.org/Indirect:ConvertToEnergy http://www.mantidproject.org/Indirect:Indirect_Data_Analysis http://www.mantidproject.org/Indirect:Indirect_Bayes
Finally, as always, do a code inspection.
comment:14 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:15 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8333_indirect_inst_name_and_run'
Full changeset: edb20577bf5e3fb766b69f875573feb8de61c8c5
comment:16 Changed 7 years ago by Roman Tolchenov
Merge remote-tracking branch 'origin/feature/8333_indirect_inst_name_and_run'
Full changeset: 067a8ff56b53ebfefd4b5d0e2970507dd1310128
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9178
bulk move to assigned at the into of the triage step