Ticket #8349 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[Muon] Prevent the plot window from moving around the screen

Reported by: Arturs Bekasovs Owned by: Arturs Bekasovs
Priority: critical Milestone: Release 3.1
Component: Muon Keywords:
Cc: Blocked By: #4166
Blocking: Tester: Keith Brown

Description

We definitely need to finally solve this, as Muon scientists are really unhappy about it.

From Stephen Cottrell:

The second, the way the graph window moves randomly around the screen (and even between screens!) is a real problem. Francis has just been to see me to complain … we need to find a solution. If there’s no simple method for keeping the window position fixed on the screen then perhaps we should consider attaching it to the ‘Muon Analysis’ interface in the way you’re proposing for the ‘plotasym’ interface. In this case it would be good to have an option in the ‘Settings’ tab for a ‘Docked’ or ‘Floating’ window

Change History

comment:1 Changed 7 years ago by Arturs Bekasovs

  • Blocked By 4166 added

After discussing the problem with Martyn, we've came to the conclusion that #4166 will help to solve this problem. In that case I'll be able to use an existing window if "Overwrite" option is enabled.

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Status changed from new to inprogress

#4166 is quite general and touches other stuff, so can implement other bits and pieces here while it gets verified.

comment:3 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Made floating window placement a bit smarter.

We are still cascading, but is previous place is free - we use it again.

Changeset: 88d71bc8e2ca28d20cd35a9a86bd2d74cf8aea52

comment:4 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Don't plot ws again if plot already exists.

Just make sure the plot is visible in that case. It should've been updated automatically.

Changeset: 5751e4ba0214988223442b519733bcac5071de47

comment:5 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Use plotSpectrum for setting plot style.

As we can now plot to the same window, no need to set style parameters manually.

Changeset: e3bb361f9e6dc664fed6c7550a69af44e03aa2c7

comment:6 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Removed big function which wasn't actually needed.

Changeset: f2ef3eb1fa605eb2f3fae5533623ee65ff2e28ca

comment:7 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Use plotSpectrum instead of checking/plotting manually.

Changeset: 32c4ca3f7113f4d41ddaa471e51423f434a029b0

comment:8 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Made plotSpectrum get plot style params itself.

Changeset: 480dd6a9e2decdb2820077c23b68980f78b08b5c

comment:9 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Removed unused closePlotWindow.

Changeset: cda29de9149c63246d67c4bccbb9b9c23ad20aeb

comment:10 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Quick fix for the problem I've found.

Don't show fitting results in the workspace selector on DA tab. When fitting is done, they do get deleted before creating a new ones. Property browser is subscribed to deletion events but not to addition events, which causes problems in that case.

Changeset: 75a9c63eb72ae3166fa92e3fde1369a332d8a74d

comment:11 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Don't show all graphs when uncheking "Hide prev. graphs"

As now they all share the same place, when all shown they are hidden behind a single graph.

That's a simple solution, need to discuss whether scientists want something different to happen.

Changeset: 2a1aeaf469bd9b78a339906cbc7d949f51cbb35e

comment:12 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Don't delete existing workspace and close it's plot.

The workspace will get overwritten and it will cause existing plot to be updated automatically.

Plus refactored a function, as with mentioned functionality removed it looked too big for what it was doing.

Changeset: e1d953014efc8bcba69da869dfb9727213af37c1

comment:13 Changed 7 years ago by Arturs Bekasovs

Leaving until next Meeting with Muon scientists so we can discuss what else should be done here.

comment:14 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Merge remote-tracking branch 'origin/master' into 8349

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/MuonAnalysis.h Code/Mantid/MantidQt/CustomInterfaces/src/MuonAnalysis.cpp

Changeset: 6f5842d05c4945ba013d939f97046d055c3804bc

comment:15 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Fixed Qt warnings.

Changeset: 5eeafd80251cb70ca7bb76c96f43e1d71271a71a

comment:16 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Got rid of all the wsIndex uses.

It was needed because for some reason previously workspaces with group held the data of all the groups, not just for the one. In one of the tickets I've fixed it so now we should always have one wsIndex only.

Changeset: 9fd8114066731db590d06aea0fcf340a9a6b637f

comment:17 Changed 7 years ago by Arturs Bekasovs

Refs #8349. Removed function accidentally left after merge.

Changeset: c4c861120d4f682cf03d3a3ee53ae4b16112fba7

comment:18 Changed 7 years ago by Arturs Bekasovs

Tester:

Better be Windows user.

A couple of improvements were done here:

  1. When graphs are set to be created as floating windows, and Overwrite option is enabled, graph window should not be moved with every graph update, but stay still. In the same way it applies to a situation when Overwrite is disable but Hide prev. graphs options is enabled.
  1. When Overwrite option is enabled, if the type of plot has not changed an existing window should be used. E.g. if we plot asymmetry of long pair of MUSR00015189, resize/move the plot window and then change e.g. binning parameters, the plot should get updated but the window shouldn't change it's size or position. Though when Overwrite option is disabled, new window is created for every change.
  1. No matter whether Overwrite is enabled or not, changing style parameters (error bars,line type,Y axis) should not affect plot window size/position.

Play with the interface a bit and make sure everything works as described.

comment:19 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:20 Changed 7 years ago by Keith Brown

  • Status changed from verify to verifying
  • Tester set to Keith Brown

comment:21 Changed 7 years ago by Keith Brown

  • Status changed from verifying to closed

Windows behave as described. Merge has been done, macro didn't post here or close it.

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9194

Note: See TracTickets for help on using tickets.