System tests leave artefacts that need cleaned up

[Keith Brown]

Some System tests aren't deleting any files they create and it can interfere with other tests.

Those tests need fixing so they clean up after themselves.

[Keith Brown]

(In #7732) #8374 is blocking this as the system tests need cleaning before this will pass them.

[Keith Brown]

Refs #8374 HFIRBackgroundAPIv2 no longer leaves files behind

Implemented cleanup in all the tests contained in HFIRBackgroundAPIv2.py, removing all the files it leaves behind.

Changeset: a0600c06446ca0abee373eb44a629e5ff8d024ef

[Keith Brown]

Refs #8374 HFIRTestsAPIv2 no longer leaves files behind

Implemented cleanup in HFIRTestsAPIv2.py, removing all the files it leaves behind.

Changeset: 6e8adaa9f5b25cc69356fbdd79f76e254319c4a4

[Keith Brown]

Refs #8374 HFIREffAPIv2 no longer leaves files behind

Implemented cleanup in HFIREffAPIv2.py, removing all the files it leaves behind.

Changeset: 023c199eb5d4d4ff33d446b844a1635ad8c0687a

[Keith Brown]

Refs #8374 HFIRReductionAPIv2 no longer leaves files behind

Implemented cleanup in HFIRReductionAPIv2.py, removing all the files it leaves behind.

Changeset: 91098a387521a422a79220bc9f6625d56ad3804a

[Keith Brown]

Refs #8374 HFIRTransAPIv2 no longer leaves files behind

Implemented cleanup in HFIRTransAPIv2.py, removing all the files it leaves behind.

Changeset: 0024bc5ac3dbdb18d842f1f4fed0b344a1f61ad3

[Keith Brown]

Refs #8374 Cleaned up code in HFIRTestsAPIv2 and HFIRBackgroundAPIv2

HFIRTestsAPIv2.py and HFIRBackgroundAPIv2.py have had their cleanup code imporved to follow better python practice and reduce repeated code.

Changeset: 609402489ea1e8786248b0c171dc47a99ac318ca

[Keith Brown]

Refs #8374 EQSANS Tests no longer leave files behind

EQSANSTransAPIv2.py, EQSANSBeamCurrentAPIv2.py, EQSANSDarkCurrentAPIv2.py, EQSANSEffAPIv2.py, EQSANSIQOutputAPIv2.py, EQSANSProcessedEffAPIv2.py and EQSANSSolidAPIv2.py have had cleanup implemented, removing all the files they leave behind.

Changeset: ec44f93df697a39b8a45958746d65f3c405b3a4a

[Keith Brown]

Refs #8374 SNSPowderRedux no longer leaves files behind

Implemented cleanup in SNSPowderRedux.py, removing all the files it leaves behind.

Changeset: dffe9473b5b2a9ab9c33db1cddba2310b8e0c4aa

[Keith Brown]

Refs #8374 LOQAddBatch no longer leaves files behind

Implemented cleanup in LOQAddBatch.py, removing all the files it leaves behind.

Changeset: 91a5051c0d1e8f60a6c52aa2ee0c129e017c1e59

[Keith Brown]

Refs #8374 Diffraction_Workflow_Test no longer leaves files behind

Implemented cleanup in Diffraction_Workflow_Test.py, removing all the files it leaves behind.

Changeset: 50ad74dee639918a8117952e3753532e768ed2cd

[Keith Brown]

As of this moment, these changes should get rid of 26 files which were originally left behind after their tests completed

Just running the system tests manually locally to see if there are any more

[Keith Brown]

System tests have finished, no more files remain to clean up

To Tester, make sure all the tests pass and that they don't leave any files behind

[Keith Brown]

This ticket was done solely in the systemtests repository

[Russell Taylor]

Good work, but you've missed just one which comes from CalibrateRectangularDetector_Test. This test only runs on Red Hat 6, and as you may not have easy access to that I'll tell you exactly how to fix it...

You need to add the following method to both PG3Calibration & PG3CCCalibration:

def cleanup(self):
    os.remove(self.saved_cal_file)

[Keith Brown]

Refs #8374 Added fix for CalibrateRectangularDetector_Test

Russell told me about a test that I'd missed, but as it only runs on Red Hat 6 I wouldn't have seen it.

He supplied a fix which i've added to the appropriate places.

Changeset: 3b7bcaa38cbd8d060170da60290e2a2ad3052aa4

[Russell Taylor]

Merge remote branch 'origin/feature/8374_clean_up_tests'

Full changeset: ​731780e07d8f9d13f44dc434b455f507437a444b

[Stuart Campbell]

This ticket has been transferred to github issue ​9219