Ticket #8387 (closed: fixed)
[IBayes] Quasi does strange things when run multiple times
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | spencer.howells@… | Blocked By: | |
| Blocking: | Tester: | Roman Tolchenov |
Description (last modified by Samuel Jackson) (diff)
Reported by Franz. Running Quasi first with a corrected reduced file, then with a uncorrected reduced file one causes issues with locating the files output from the Fortran code.
IOError: [Errno 2] No such file or directory: 'C:/Users/lhs18285/Documents/mantid_workspace/osi95119_graphite002_QLr.ql1' at line 2 in '<Interface>' caused by line 333 in 'C:/Users/lhs18285/Documents/GitHub/Mantid/Code/Mantid/scripts/Inelastic\IndirectBayes.py' caused by line 434 in 'C:/Users/lhs18285/Documents/GitHub/Mantid/Code/Mantid/scripts/Inelastic\IndirectBayes.py'
For starters it would be better if the files generated by the Fortran code were removed after we're finished with them anyway.
Attachments
Change History
comment:1 Changed 7 years ago by Samuel Jackson
I've added the files used by Franz which should be able to reproduce the error.
comment:3 Changed 7 years ago by Samuel Jackson
- Status changed from new to inprogress
Refs #8387 Updated Bayes scripts to clear Fortran arrays.
Also added code to tidy up the generated files if you didn't choose to save the output.
Changeset: dcfd895a932272ff05f6a7303ef71bcaa13429af
comment:4 Changed 7 years ago by Samuel Jackson
Refs #8387 Recompiled to remove print line statement.
Changeset: f483ade7422a21df428d03a77069dd6022e262bf
comment:5 Changed 7 years ago by Samuel Jackson
Refs #8387 Updating Win32 libs
Changeset: 46d190d4b46f77fb5ab157d7a95882f6fa2e0ae9
comment:6 Changed 7 years ago by Samuel Jackson
Refs #8387 Recompiled 64bit version of bayes scripts.
Changeset: fd402dac4dc0f1e5fe97e7decf072f0931b69086
comment:7 Changed 7 years ago by Samuel Jackson
Refs #8387 Remove code for cleaning up files.
This could lead some bad logic and suprises for the user.
Changeset: 307d04541060d8e8e27ab26b877ff9c4a4339a7c
comment:9 Changed 7 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
To Tester
The issue here was that the character arrays used to store the name of the file in the Fortran code wasn't being cleared before being reused. Therefore when you ran with a long file name, then with a shorter file name you got the described error as the file would be written to the wrong name.
This was present in three of the Bayes routines (ResNorm, Quasi and Stretch). First check you can reproduce the error, then check the system tests the listed functions are passing. Follow the instructions on the wiki and run though and check each one of the interfaces still works.
comment:10 Changed 7 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:11 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to reopened
- Resolution fixed deleted
Quasi crashes mantid when I try to run it.
comment:12 Changed 7 years ago by Samuel Jackson
- Status changed from reopened to verify
- Resolution set to fixed
comment:14 Changed 7 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/8387_Quasi_multi_runs'
Full changeset: 3ae691718619247d89dd939897c96d06ec6bdb8f
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9232
