Ticket #8388 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[IDA] Elwin and MSDFit - update to correct temperature normalisation

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.1
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Alex Buts

Description

Update from Spencer:

Elwin:

  • Lines 284-5 : save first run info
  • Lines 372-384 : added CopyLogs & changed to vert_axis
  • Lines 386-413 : corrected T-normalise now creates a new WS *_elt
  • Lines 441-5 : save elt WS

MSDFit

  • Line 948-9 : becomes vert_axis to be consistent with above
  • Lines 1004-6 : added Sample logs

Attachments

IndirectDataAnalysis.py (50.4 KB) - added by Samuel Jackson 7 years ago.
Updated version of the script

Change History

Changed 7 years ago by Samuel Jackson

Updated version of the script

comment:1 Changed 7 years ago by Samuel Jackson

  • Cc spencer.howells@… added

comment:2 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8388 Created new workspace normalised to lowest temp.

Tidied up some of the Elwin code at the same time.

Changeset: 7a275a4d4d9d5ee07933dcdbefef17d3709aaeac

comment:3 Changed 7 years ago by Samuel Jackson

Refs #8388 Missed passing option to save function.

Changeset: 38fb910ebc66d14a6d9142cca8aee25129bec720

comment:4 Changed 7 years ago by Samuel Jackson

Refs #8388 Fix compatibility with MSDfit.

Also copy logs from run to generated workspaces.

Changeset: 5f525744f4a60263cb764b6c760efb1a55375e72

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

You'll need to run through the Elwin interface and check that the normalise to lowest temp option now creates a separate workspace with the temp normalised to the lowest value.

I've also updated MSDfit to include use the corrected name of the sample log (vert_axis) stored in the elf workspace output by Elwin. MSDFit also had the same issue as Elwin had where decreasing temperature data had to be flipped to follow natural ordering, so be sure to plot the output of MSDfit and check the plot for temperature looks correct.

comment:6 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.1

comment:7 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:8 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Refs #8388 eltWS wasn't initialised before use in one code path.

Changeset: 7bd8f8bd0a2375c277117d05717839275963d712

comment:9 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 7 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:11 Changed 7 years ago by Alex Buts

It do certainly flips the axis from min to max on edges though the temperature axis does not look like sorted.

The ticket purpose is achieved, though sorting may be another issue to look for.

comment:12 Changed 7 years ago by Alex Buts

  • Status changed from verifying to closed

Merge branch 'feature/8388_correct_temp_normalisation'

Full changeset: 80ed3a662d4824c2f46cbb869cbb737bd9a9ef5a

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9233

Note: See TracTickets for help on using tickets.