Ticket #8396 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

LoadFullprofResolution change OutputWorkspace to OutputTableWorkspace

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: major Milestone: Release 3.1
Component: Diffraction Keywords:
Cc: zhouw@… Blocked By:
Blocking: Tester: Wenduo Zhou

Description

For the LoadFullprofResolution algorithm change the name of the parameter OutputWorkspace to OutputTableWorkspace

A systemtest(s) may need updating also.

Wenduo if you know which systemtest needs updating do not hesitate to add a comment to this ticket

Change History

comment:1 Changed 7 years ago by Karl Palmen

I found no occurrence of the string 'FullprofResolution' in any of thre system test python files.

comment:2 Changed 7 years ago by Karl Palmen

  • Status changed from new to inprogress

comment:3 Changed 7 years ago by Karl Palmen

Change property name in algorithm and unit test re #8396

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: a6f559b70865bc3a7f95de626c303746a007458d

comment:4 Changed 7 years ago by Karl Palmen

Change a variable name re #8396

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 18511b1ed2009df95cb00268a44ad6d2f86eed14

comment:5 Changed 7 years ago by Karl Palmen

Fix two references to LoadFullprofResolution re #8396

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: f6c70614f50809f8cda5e422888417a67322d867

comment:6 Changed 7 years ago by Karl Palmen

To test just check appropriate changes have been made in the code review. You may also run the unit tests you find in the code review.

comment:7 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8396_output_table_workspace'

Full changeset: abda5be5c31cb742f6c0531f4b0da203229cb6ff

comment:10 Changed 7 years ago by Karl Palmen

Ensure Table Workspace is always output re #8396

Also extended unit test a little.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 83640cd009ad0da72d4a5374c8e380cb8263e2cc

comment:11 Changed 7 years ago by Karl Palmen

Partial fix re #8396

Parameter values make it to the XML string, but not yet all the way to the unit test.

DO NOT GIT CHECKBUILD

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: dd3dfb6475519fdbc69db8fd29b9553fddfa572b

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9241

Note: See TracTickets for help on using tickets.