Ticket #8398 (closed: fixed)
LoadFullprofResolution add optional Workspace Property
Reported by: | Anders Markvardsen | Owned by: | Karl Palmen |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Diffraction | Keywords: | |
Cc: | zhouw@… | Blocked By: | #8546 |
Blocking: | #8400 | Tester: | Anders Markvardsen |
Description (last modified by Karl Palmen) (diff)
- Add optional Workspace property to LoadFullprofResolution, initially keeping OutputTableWorkspace property compulsory
- In new method of LoadFullprofResolution transfer the functionality from ConvertFullprofToXML into this method.
The outcome of this is that if LoadFullprofResulution is run with a GEM workspace and with parameter Filename equal to a GEM .irf file that the .irf instrument parameters gets stored in the workspace
At this point have the Banks parameter have no effect on the above
Change History
comment:4 Changed 7 years ago by Karl Palmen
- Description modified (diff)
- Summary changed from LoadFullprofResolution add optional Workspace parameter to LoadFullprofResolution add optional Workspace Property
comment:5 Changed 7 years ago by Karl Palmen
Add non-functioning workspace property re #8398
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 6043245dc35ed925309cad4bf9096915322d29da
comment:6 Changed 7 years ago by Karl Palmen
Begin to write code to put params into workspace re #8398
My original plan of putting the table into a POCO XML document then putting that into the workspace like LoadParameters does is not on, because LoadParameters does something dodgy, that will sometime need fixing and should not be replicated. So I'm forced to put the parameters in directly. This would lead to better code, but I presently have no idea how to do it.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 21ce24ebc8e7b73ada914e506eb1ebd7a35bb198
comment:8 Changed 7 years ago by Karl Palmen
Add code from ConvertFullprofToXML re #8398
Untested do not git checkbuild
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: bfe30694d645b6545f08874aae27d924290587c8
comment:9 Changed 7 years ago by Karl Palmen
Complete the parameterXMLString code re #8398
Still to be tested
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 89bd573ca496e30f0eaf53d0fbee901b9066c415
comment:10 Changed 7 years ago by Karl Palmen
Begin unit test of new property re #8398
Unit test present just tests that it executes without error. Also some fixes to ensure it executes without error.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 8171401959f461614239e0b20c160a16d4c65eaf
comment:11 Changed 7 years ago by Karl Palmen
Add a not yet correct test of a parameter re #8398
Test does not pass because it is not yet correct. Do not git checkbuild.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 0cbfe355e94cf41c6af3ff11f2b66643f0772eb0
comment:12 Changed 7 years ago by Karl Palmen
In unit test access fit parameter correctly re #8398
Also name the OutputTableWorkspace. Unit test passes, so a git checkbuild may be done.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 89683602db5b4c1b82b8a5f2f3f0a388e16b3ff7
comment:13 Changed 7 years ago by Karl Palmen
Add other parameters to unit test and tidy re #8398
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 7ac64e46add83ec57f226fa9caff7a10bf99df52
comment:14 Changed 7 years ago by Karl Palmen
- Status changed from inprogress to verify
- Resolution set to fixed
To test, check the the unit test is correct and adequate.
You may also run LoadFullprofResolution with the Workspace set to a previously loaded workspace with and instrument and then check the default IkedaCarpenter parameter values in that workspace.
comment:15 Changed 7 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester set to Anders Markvardsen
comment:16 Changed 7 years ago by Anders Markvardsen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8398_workspace_property'
Full changeset: c0555c235295721387c67937ce81c6194847d2d4
comment:17 Changed 7 years ago by Anders Markvardsen
Tested with GEM example
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9243