Ticket #8433 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Algorithms damage output workspace groups when execution fails

Reported by: Arturs Bekasovs Owned by: Nick Draper
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

If InputWorkspace and OutputWorkspace are both set to the same workspace group and an error occurs during algorithm execution - the workspace group will be emptied, with all its members popping out to the ADS. I would expect it to be left untouched if an algorithm did not succeed.

To reproduce:

  1. Save dead_times.nxs to your hard-drive and load it in MantidPlot.
  2. Load AutoTestData/MUSR00015189.nxs. Note that it gets loaded as a workspace group with two members.
  3. Open the dialog of ApplyDeadTimeCorr algorithm.
  4. Set both InputWorkspace and OutputWorkspace to MUSR00015189.
  5. Set DeadTimeTable to dead_times.
  6. Run the algorithm. Note that error is printed to the log-console, which means that the algorithm didn't succeed. However, MUSR00015189 is now empty and all it's members are ungrouped.

Attachments

dead_times.nxs​ (12.9 KB) - added by Arturs Bekasovs 7 years ago.
Dead Time Table file

Change History

Changed 7 years ago by Arturs Bekasovs

Dead Time Table file

comment:1 Changed 7 years ago by Arturs Bekasovs

  • Milestone changed from Release 3.1 to Backlog

This is better to do at the beginning of the next iteration.

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:3 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Arturs Bekasovs to Anyone

comment:4 Changed 6 years ago by Nick Draper

  • Owner changed from Anyone to Nick Draper
  • Status changed from assigned to verify
  • Resolution set to wontfix

Not possible with current design without copying the data. No users have reported problems with this.

comment:5 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:6 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

comment:7 Changed 6 years ago by Nick Draper

  • Milestone changed from Backlog to Release 3.4

moved to r 3.4 as tickets are closed

comment:8 Changed 5 years ago by Nick Draper

  • Resolution changed from wontfix to fixed

Somehow these slipped through without a resolution. Set to Fixed.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9277

Note: See TracTickets for help on using tickets.