Ticket #8437 (closed: fixed)
More cppcheck style warnings
Reported by: | Nick Draper | Owned by: | Nick Draper |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Framework | Keywords: | Maintenance |
Cc: | Blocked By: | #8418 | |
Blocking: | Tester: | Samuel Jackson |
Description
Change History
comment:2 Changed 7 years ago by Nick Draper
- Status changed from new to inprogress
re #8437 lots of style issues, but not quite all
Changeset: 0c15c77a6bc7e9a43cde2f6e1b900320db847760
comment:3 Changed 7 years ago by Nick Draper
re #8437 catching a couple of warninga
Changeset: 6c89abaa0a1eaaa54cf955ba854156d0cfa59b41
comment:4 Changed 7 years ago by Nick Draper
re #8437 and another warning
Changeset: 29e84f226ed0fe4ad6f59cc4bc02308f9b26fe65
comment:5 Changed 7 years ago by Nick Draper
- Blocked By 8418 removed
To test:
- FIRST test and Merge #8418
- Check the code builds and passes unit tests
http://download.mantidproject.org/jenkins/job/is_inc_rhel6_develop/2722/ The warning here was cleared by the last commit
- Code review - although there is a lot to go through
- After merging the number of cppcheck stlye errors should reduce - it will not reach 0
comment:6 Changed 7 years ago by Nick Draper
- Status changed from inprogress to verify
- Resolution set to fixed
comment:8 Changed 7 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester set to Samuel Jackson
comment:9 Changed 7 years ago by Samuel Jackson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8437_cppcheck_style'
Full changeset: 023312dcb867de6a7bd267bcf17c898dde869e08
comment:10 Changed 7 years ago by Samuel Jackson
Code builds, tests are passing and the code changes look good.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9281
NOTE TO TESTER: Ticket #8418 must be tested and merged before this ticket.