Ticket #8444 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Improve the way we do reduction of multi period data

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: major Milestone: Release 3.1
Component: SANS Keywords:
Cc: peter.parker@… Blocked By: #8443
Blocking: #8505 Tester: Peter Parker

Description

This will be an important step for LARMOR which intends to have multi-period event files for their spin echo experiements.

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Gesner Passos

We should be able to execute this script and get as output a group workspace with the reduced data.

from ISISCommandInterface import * 
SANS2D()
Set1D()
Detector("rear-detector")
MaskFile('MASKSANS2Doptions.091A')
Gravity(True)
AssignSample('5512')
reduced = WavRangeReduction()
Last edited 7 years ago by Gesner Passos (previous) (diff)

comment:3 Changed 7 years ago by Gesner Passos

re #8444: Allow reduction of multiperiod data

Changeset: bdd2be07c321298fede76d8e2bee6b4bfdc374c7

comment:4 Changed 7 years ago by Gesner Passos

re #8444: Rename variable wksp_name

Changeset: f9280bf50b5133df3e52ed11272ab2b5ff8bd6d5

comment:5 Changed 7 years ago by Gesner Passos

re #8444: Revise LoadRun and LoadSample to support group workspace

Changeset: 8f7af6853b7f5f300ebff66fd5fe780bfeb7f867

comment:6 Changed 7 years ago by Gesner Passos

re #8444: Do not use protected attribute _period outside LoadRun

Improve the way we get the period name

Changeset: 3052ea90890902ba33b827f538709b8c3c0df59d

comment:7 Changed 7 years ago by Gesner Passos

re #8444: Move check outside LoadSample

LoadSample itself should not care about this. This will allow the creation of the tests on the load as well.

Changeset: 1906137d17819b3d65db9b6af90df16450585877

comment:8 Changed 7 years ago by Gesner Passos

re #8444: Support multiperiod reduction

Changeset: d2255c869153e9fbf571fdb676746bf4c43a3ed9

comment:9 Changed 7 years ago by Gesner Passos

re #8444: Correct the usage of period in the output name

The output name should show period only if the workspace has many periods or if the user defined which period to run.

Changeset: ffab3157867d1ca8b170a7da2bc1a167692a6a39

comment:10 Changed 7 years ago by Gesner Passos

re #8444: Ensure that suffix is correctly applied

Changeset: 65592a63450b3326be2c7c76645ecad34222b355

comment:11 Changed 7 years ago by Gesner Passos

re #8444: LoadRun corrections

1 - It corrects the access to multiperiod data. It uses the _index_of_group and not _period which is not changed internally by LoadRun (keeps memory of the way it was initialised) 2 - It corrects the wrong assumpition that the datafile will have the runnumber correctly placed. It asks the workspace its runnumber.

Changeset: 320ca8de73586f57a0b2f7b8cc886a42b854d728

comment:12 Changed 7 years ago by Gesner Passos

re #8444: Create SystemTest to enforce Loaders behaviour

Changeset: 0a218fa911a5eaa5b70b938bec7a9693c80f15c8

comment:13 Changed 7 years ago by Gesner Passos

re #8444: SystemTest to ensure reduction of multiperiod

Changeset: 22bd71fddea6070b4fe93ad6f7aeaee263879c37

comment:14 Changed 7 years ago by Martyn Gigg

Ban new csv file from LoadLotsOfFiles.

Refs #8444

Changeset: fb9ac0cd956c4c1a1db7289462d34596a7276a51

comment:15 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/8444_multiperiod_data' into develop

Conflicts:

SystemTests/AnalysisTests/LoadLotsOfFiles.py

Refs #8444

Changeset: a5b51f6b9e090d597b02583fd9668f349132d102

comment:16 Changed 7 years ago by Gesner Passos

re #8444: GUI support for multiperiod

Changeset: 9ed5fbfc558eea255b2a9d8a61a5fa2327ac0e3f

comment:17 Changed 7 years ago by Gesner Passos

re #8444: Delete temporary Workspaces

Changeset: bef39018c10a9628c4b622e589666117556d2668

comment:18 Changed 7 years ago by Gesner Passos

  • Blocking 8505 added

comment:19 Changed 7 years ago by Gesner Passos

re #8444: Avoid breaking tests in xp for memory issue

Changeset: efe850246b36304d2d71e8ed0bee4730a81cbc5e

comment:20 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:21 Changed 7 years ago by Gesner Passos

  • Cc peter.parker@… added

comment:22 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:23 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8444_multiperiod_data'

Full changeset: c0e19043ed739627240dba04b7de8083993f11d4

comment:24 Changed 7 years ago by Peter Parker

Merge remote-tracking branch 'origin/feature/8444_multiperiod_data'

Full changeset: c41dfa1837fcc868a70a7d7f4889e0feaf60c1b1

comment:25 Changed 7 years ago by Gesner Passos

Merge branch 'feature/8444_multiperiod_data' into feature/8505_slicing

Full changeset: 068abec9119d4925b7ff4aca42e68f6c12833bfc

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9288

Note: See TracTickets for help on using tickets.