Ticket #8450 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

drag into script interpreter

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.1
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Keith Brown

Description

If possible

  1. workspace -> import statement
  2. file -> if .py execfile statement
  3. text -> paste

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to inprogress

re #8450 drop drop workspace names to ipython

Changeset: ff6fdb75b496d89d5aa158475a77aea405025f09

comment:2 Changed 7 years ago by Russell Taylor

Re #8450. No C++11 range-based for loop in gcc 4.4.

But here we can use the Qt foreach construct instead.

Changeset: e64882ce5499b63fa945f3a8c6b71b975e13743b

comment:3 Changed 7 years ago by Nick Draper

re #8450 dragdrop added, had to rearrage some of the other drops

Changeset: aa69b2db210e0f099948aaffe0a1a7938dfe9756

comment:4 Changed 7 years ago by Nick Draper

re #8450 more foreaching

Changeset: 3bf81f3d14b7f1fdaf6f39a91ba2ef95ac7dba18

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  1. drag text onto the script interpreter
  2. drag one or more workspaces onto the script interpreter
  3. Drag a file onto the script interpreter ("it puts on the filename - that is as much as we can do here.

There were some other changes so also test:

  1. drag one or more workspaces onto the Main (grey) mdi window
  2. drag data files onto the main mdi area
  3. drag py files onto the main mdi area
  4. drag data files onto the workspace toolbox

comment:6 Changed 7 years ago by Keith Brown

  • Status changed from verify to verifying
  • Tester set to Keith Brown

comment:7 Changed 7 years ago by Keith Brown

Changes work rather well and as expected (with a couple of exceptions restricted by ipython it seems)

A minor point of concern was that if a file is dragged from a file manager window, and that file take a while to load, it causes a noticeable lock of the file manager window while mantid is loading the file. It's been deemed 'ignorable until it becomes an issue' as I've tried preparing a very meaty file and giving it to MS word in the same way to see if MS Word locks the file manager window while it loads it - it doesn't, thus this could ultimately be fixable, but until a user reports it we'll deem this lock okay as it'll probably be more trouble than it's worth to solve for the little we get out of it.

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge branch 'feature/8450_script_interpreter_dragdrop' of github.com:mantidproject/mantid into feature/8450_script_interpreter_dragdrop

Full changeset: 657a912da7883f40e900b92855dd53e1405f90cd

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from Framework to User Interface

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9294

Note: See TracTickets for help on using tickets.