Ticket #8465 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

refactor out toLam

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

quick.py has a toLam function. We need to convert the entire of quick to an algorithm (#8371). This is best done bottom-up, which means converting toLam to an algorithm first or refactoring it out to a separate module

This should be quite safe to do, as I've already provided test coverage for the quick scripts.

toLam is a horrible function, and should definitely be refactored in the process of moving it anywhere.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to verify
  • Owner changed from Owen Arnold to Harry Jeffery
  • Resolution set to fixed
  • Milestone changed from Backlog to Release 3.3

This has been completed, and the toLam no longer exists in any python code.

Easiest way to confirm this: git grep toLam

The only matches will be in cpp/h files.

comment:3 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:4 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9309

Note: See TracTickets for help on using tickets.