Ticket #8472 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Improve the usability of ProcessBackground

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Vickie Lynch

Description

Now in functional option 'Select background points', users will have to do a fitting in MantidPlot, which is not convenient.

Add an option such that this algorithm will fit the selected background points before it is returned.

Attachments

PG3_15035-3.dat (321.4 KB) - added by Wenduo Zhou 7 years ago.
verify8472.py (708 bytes) - added by Wenduo Zhou 7 years ago.

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to inprogress

Added 2 more algorithm properties. Refs #8472.

Changeset: 7a38ac156c903e9f0a57b7e9ee6c73dd9309c4ff

comment:2 Changed 7 years ago by Wenduo Zhou

Made the new feature work. Refs #8472.

Changeset: 172f80565bdd1ba4d0a0ff1826a1a93753cc0d13

comment:3 Changed 7 years ago by Wenduo Zhou

Expanded unit test for new feature. Refs #8472.

Changeset: 1b78d72d8a171f11b8ffe0b49c09ce70fa52f552

comment:4 Changed 7 years ago by Wenduo Zhou

For tester

  1. Download the files
  2. Run script verify8472.py
  3. You should see that there are 3 spectra in output workspace PG3_15035_Bkgd01. Spectrum 2 is the fitted background; and spectrum 3 is the difference. Output workspace PG3_15035_BkgdParameter01 contains the parameters' fitted value. It can be used as the input ProcessBackground.

comment:5 Changed 7 years ago by Wenduo Zhou

Renamed a property b/c python. Refs #8472.

Changeset: 95e6bdf77aaddb0ff722ff692885df4e1f61e009

Mantid's python script does not accept any WorkspaceProperty whose name does not end with Workspace.

Last edited 7 years ago by Wenduo Zhou (previous) (diff)

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

comment:6 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:7 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:8 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The output workspace is not suitable as an input "BraggPeakTableWorkspace" of ProcessBackground as asserted, because the following error occurred when I attempted to run ProcessBackground

Input Bragg peak table workspace does not have TOF_h and/or FWHM

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from reopened to verify
  • Resolution set to fixed

The new feature is only applied to function option (i.e., 'Option') being 'SelectBackgroundPoints'. BraggPeakTableWorkspace is an optional input required by 'Option' equal to 'RemovePeaks'.

Meanwhile, BraggPeakTableWorkspace is a table workspace requiring 2 columns, TOF_h and FWHM. This error message means that the input BraggPeakTableWorkspace is not correct.

comment:10 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester changed from Karl Palmen to Gesner Passos

comment:11 Changed 7 years ago by Gesner Passos

Variation of the script outputs error:

LoadAscii(Filename=r'PG3_15035-3.dat',OutputWorkspace='PG3_15035-3',Unit='TOF')
ProcessBackground(InputWorkspace='PG3_15035-3',OutputWorkspace='PG3_15035-Bkgd01',Options='SelectBackgroundPoints',SelectionMode='FitGivenDataPoints',BackgroundOrder='6', 
	BackgroundPoints='10082,10591,11154,12615,13690,13715,15073,16893,17764,19628,21318,24192,35350,44212,50900,60000,69900,79000',NoiseTolerance='0.5',
	UserBackgroundWorkspace='UserObserver',OutputBackgroundParameterWorkspace='PG3_15035_BkgdParameters01', OutputBackgroundType='FullprofPolynomial')

ValueError: Background of type FullprofPolynomial is not supported.

comment:12 Changed 7 years ago by Gesner Passos

Is this expected?

comment:13 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to verify
  • Tester Gesner Passos deleted

comment:14 Changed 7 years ago by Wenduo Zhou

Removed background option FullprofPolynomial. Refs #8472.

Changeset: 64a359f0f2f4a267df8c354fb790b9ffa35fdf14

comment:15 Changed 7 years ago by Wenduo Zhou

  • Status changed from verify to reopened
  • Resolution fixed deleted

Support for FullprofPolynomial requires more input properties and unit test. It will be solved in a new ticket. For this ticket, the option to use this background function is removed.

comment:16 Changed 7 years ago by Wenduo Zhou

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:17 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:18 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/8472_process_bkgd_semiauto'

Full changeset: f81278f9e4c6655c765d0680e62992ef8316d8d2

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9316

Note: See TracTickets for help on using tickets.