LoadMD does not load MD workspaces, generated by MergeMDFiles any more

[Alex Buts]

Algorithm: LoadMD v1 Parameters:

Name: Filename, Value: /home/wkc26243/Fe400/fe400_8k.nxs, Default?: No, Direction: Input Name: MetadataOnly, Value: 0, Default?: Yes, Direction: Input Name: BoxStructureOnly, Value: 0, Default?: Yes, Direction: Input Name: FileBackEnd, Value: 1, Default?: No, Direction: Input Name: Memory, Value: 400, Default?: No, Direction: Input Name: OutputWorkspace, Value: wd4, Default?: No, Direction: Output

Error in execution of algorithm LoadMD: NXgetattr(dimension0) failed

The location of files which fail, the script to generate it and the sample are in special system test directory, will be added to this ticket a bit later.

[Alex Buts]

refs #8480 just created branch

Changeset: d9c03d4a8fb93877c002d9a898e63d5741fd592a

[Alex Buts]

refs #8480 changed nexus file holder to scope pointer

as it was locking file on failure (and probably caused memory leak)

Changeset: 4f21c67c44e04d98f8ec7f3e12b6319bff483588

[Alex Buts]

refs #8480 Should fix the issue, but testing is needed

Changeset: 49360304dbe680bab1d472e81c966a8fbf2fb5a3

[Alex Buts]

refs #8480 fixed unit tests compilations

Changeset: 7495d10c80badd228df522a0d602d373f82488f9

[Alex Buts]

refs #8480 Fixed MDEvents test

Changeset: d5221e0446a5b008440caa22f2383aaa2357ea87

[Alex Buts]

refs #8480 final changes should fix the issue

Changeset: 22b3da755f40dc927e2df2bd219331f179d49faa

[Alex Buts]

refs #8480 syntax changes for some very strict compiler

Changeset: 586456d31e890c97aa5a1d36a17f4a18be31f88c

[Alex Buts]

refs #8480 Added missing part of SaveMD

Changeset: 4584dd4349c94ac90dc0391d44d560c95e76ab5c

[Alex Buts]

refs #8480 minor changes

probably unnecessary any more but just to make it equivalent to SaveMD

Changeset: a5ff1353cdf5e88244b5c5f6b56f36b6911bc8ca

[Alex Buts]

refs #8480 Added check if target file already exist

Changeset: e85b6ab65add7c9a4a74b35ae216ccff22ea2d35

[Alex Buts]

refs #8480 Should fix unit test failure

Changeset: 2e1a22f3714a71620d9de9fc7d80da192964b2fe

[Alex Buts]

refs #8480 Doxygen warnings

Changeset: abc7b96bc9a6375ada39e31c5eefa4cedd1800b4

[Alex Buts]

1) The code behind this piece of work due to substantial refactoring, so I used this opportunity to do small part of it.

2) The reason behind the failure is missing part of information (not)written by MergeMD files. This has been fixed and now you should be able to take a file (any nxspe will do), convert it to MD, saveMD and loadMD it back or MergeMDFiles with file-based target, delete workspace and LoadMD back. These two ways of doing thins should produce identical results. Old code was failing on LoadMD after MergeMDFiles and this should be now fixed.

3) I am making another ticket to increase test coverage of this area of code (some kind of refactoring is already there).

[Martyn Gigg]

Tested with different combinations on the BuildSQW test with single & multiple file merges. Everything seems to work as expected now. The produced file can be saved & loaded again to produce identical results, i.e CompareMDWorkspaces is happy.

[Martyn Gigg]

Merge remote-tracking branch 'origin/bugfix/8480_LoadMDafterMergeMDFiles'

Full changeset: ​fe2296e4d3854f18c33e6413ba3065231ea84b82

[Stuart Campbell]

This ticket has been transferred to github issue ​9324