Ticket #8484 (closed: fixed)
Fix unreleased use of POCO::XML document and nodelists in Algorithms code
Reported by: | Karl Palmen | Owned by: | Federico M Pouzols |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Framework | Keywords: | maintenance |
Cc: | Blocked By: | ||
Blocking: | #10637 | Tester: | Harry Jeffery |
Description (last modified by Karl Palmen) (diff)
In the code of framework/Algorithms I found three cases of POCO::XML document or nodelist objects being created, but not released. This could cause memory leakage. Fix by using AutPtr for the object.
The three cases I founnd were CreateDummyCalFile, ReadGroupsFromFile, DetectorEfficiencyCorTest.
Change History
comment:4 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
bulk move to assigned at the into of the triage step
comment:6 Changed 6 years ago by Federico M Pouzols
- Owner set to Federico M Pouzols
- Status changed from assigned to inprogress
comment:7 Changed 6 years ago by Federico Montesino Pouzols
use AutoPtr to handle mem in poco xml objects, cut headers, re #8484
Changeset: c6a90e9e81a407850f940b2a339e5e4790bd92ed
comment:8 Changed 6 years ago by Federico M Pouzols
- Status changed from inprogress to verify
- Resolution set to fixed
This is a maintenance / leak cleaning ticket. The modified cpp files/classes are:
- CreateDummyCalFile.cpp
- ReadGroupsFromFile.cpp
I could not find any issue in the current DetectorEfficiencyCorTest or anywhere else.
To test:
- review code changes
- check that tests pass, especially all the algorithm tests
comment:10 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:11 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/8484_fix_unreleased_libpoco_xml_objects_in_algorithms'
Full changeset: 4427370d51ef86a00b8ef90bf00acf4ffd4e9db7
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9328
AutoPtr is preferred to release().