Ticket #8497 (closed: fixed)
Add missing factor of 2pi in OrientedLattice::hklFromQ
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Diffraction | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Michael Reuter |
Description
There is a missing factor of 2pi that needs to be divided out. This was discovered while adding OrientedLattice::qFromHKL as part of #8432. The only client code that appears to be affected is PredictPeaks.
Change History
comment:2 Changed 7 years ago by Peter Peterson
Re #8497. Missed a unit test that needed to be changed.
Changeset: 0e69da2351eaed80efa00afd8523517d9a15d298
comment:3 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is on feature/8497_two_pi.
To test: This is really a code review one. Q=2pi/d
comment:4 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:5 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8497_two_pi'
Full changeset: d02a75fc2849eb1a1338aab221884b96cf477941
Note: See
TracTickets for help on using
tickets.
Re #8497. Added in a missing factor of 2pi.
Changeset: 170480a136e85430222c72961279d8556e5f2508