Ticket #8513 (closed: fixed)
Top level exception thrown in Python script window
| Reported by: | Samuel Jackson | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | GUI | Keywords: | student |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Andrei Savici |
Description
I appears you can get Mantid to throw a top level exception by doing the following:
- Open the script window (F3)
- Type anything
- Attempt to close Mantid
- When prompted, choose to save the script.
- Now click cancel. An exception will be thrown
It may be unlikely that a user would do this, but it should be easy enough to fix.
Change History
comment:4 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Handle exception throws on script save cancel
Catches SaveCanceledException thrown when user cancels saving from the save as dialogue Refs #8513
Changeset: 334a5a7e7a121f50d7b0cdf914312c5f0fc4d1c0
comment:7 Changed 6 years ago by Dan Nixon
Caught SaveCanceledException in ScriptFileInterpreter to treat canceling from the save dialogue in the same way as selecting "Close without saving".
Original steps no longer produce the issue using either "Save" or "Save As...".
comment:8 Changed 6 years ago by Dan Nixon
Fix style warning for exception catch
Refs #8513
Changeset: 96e07a02d1477dafb0a75027fc7b2a823c12b82f
comment:9 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 6 years ago by Martyn Gigg
- Status changed from verify to reopened
- Resolution fixed deleted
The branch for this change looks like it has been based off another branch. It should be based off master.
comment:11 Changed 6 years ago by Dan Nixon
- Status changed from reopened to inprogress
Handle exception throws on script save cancel
Catches SaveCanceledException thrown when user cancels saving from the save as dialogue Refs #8513
Changeset: a7b27f74bfe3708785bef76d294e83c76a5e1b0f
comment:12 Changed 6 years ago by Dan Nixon
comment:13 Changed 6 years ago by Dan Nixon
Fix style warning for exception catch
Refs #8513
Changeset: 989e0fa2a4381247b42d7bf07942a4b01c5c0412
comment:14 Changed 6 years ago by Dan Nixon
comment:15 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:16 Changed 6 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:17 Changed 6 years ago by Andrei Savici
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/8513_fix_script_window_save_exception_new'
Full changeset: 2ba2eeaf683527aa4b0382798e9a07095ccc44c7
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9357
bulk move to assigned at the into of the triage step