Ticket #8527 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

POLREF IDF update

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: blocker Milestone: Release 3.1
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #8529 Tester:

Description (last modified by Owen Arnold) (diff)

The IDF parameters have been separated into a separate parameter file, and Keith has done a good job of ensuring that these parameters are being picked up and used as part of #8693 for all the target reflectometry instruments.

Tim has now provided a new IDF. This IDF contains both the old and newer OSMOND detector, but the detector ids have been offset and there is no intersection between the sets of IDs. Tim now wants me to replace the existing IDFs with a single updated POLREF IDF.

We have some really good system test coverage around POLREF involving both old and new data from both detector types, so providing that the system tests are passing, we can be confident that the IDF is correct.

This ticket has been re-tasked from it's original instructions.

Change History

comment:1 Changed 7 years ago by Keith Brown

  • Blocking 8514 removed

(In #8514) #8523 and #8527 no longer block as checks have been done (and finer tests will be done by scientists) and the POLREF issue is being delegated to another ticket while we wait

comment:2 Changed 7 years ago by Keith Brown

  • Blocking 8529 added

comment:3 Changed 7 years ago by Owen Arnold

  • Summary changed from POLREF IDF parameters out of date to POLREF IDF update
  • Description modified (diff)
  • Reporter changed from Keith Brown to Owen Arnold

comment:4 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #8527. Tims new IDF.

Changeset: 38364ecb504fb4a52b671f8a723098f3816671b0

comment:5 Changed 7 years ago by Owen Arnold

I've run all the system tests that this would affect and they all seem to be passing. Time for a checkbuild.

comment:6 Changed 7 years ago by Owen Arnold

Revert "refs #8527. Tims new IDF."

This reverts commit 38364ecb504fb4a52b671f8a723098f3816671b0.

Changeset: 018a923515a556c04a00f5c54545684d95deff64

comment:7 Changed 7 years ago by Owen Arnold

Revert "Revert "refs #8527. Tims new IDF.""

This reverts commit 018a923515a556c04a00f5c54545684d95deff64.

Changeset: 91a1e84928a0a8381cd8a34008b5002c5b7ee889

comment:8 Changed 7 years ago by Owen Arnold

refs #8527. Fix tests and change date range.

Changeset: a02bfed598410bb7ff9bd0fc82ea3eae7af8fc55

comment:9 Changed 7 years ago by Owen Arnold

Tester: Do not pass until you have verified that both the unit tests and system tests are passing on develop. I've kicked-off a system test job for this here ​http://download.mantidproject.org/jenkins/view/Manually%20Run%20Tests/job/isis_systemtests_rhel6/

The automated tests should provide sufficient confidence that the changes are not damaging.

comment:10 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tests seem to be passing.

comment:11 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/8527_POLREF_idf_update'

Full changeset: ​ae6eab923b1a2777428bcef7929aa11a4f94c1d5

comment:12 Changed 7 years ago by Samuel Jackson

Checked that the system tests had passed on Jenkins and ran some POLREF system tests locally. Everything appears to be passing. Did a quick code inspection and everything looks good.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9371

Note: See TracTickets for help on using tickets.