Ticket #8534 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

[Muon] New MuonCalculateAsymmetry workflow algorithm

Reported by: Arturs Bekasovs Owned by: Arturs Bekasovs
Priority: major Milestone: Release 3.1
Component: Muon Keywords:
Cc: Blocked By:
Blocking: #8494 Tester: Anders Markvardsen

Description

It should encompass calculations done in "plotPair()" and "plotGroup()" functions inside MuonAnalysis.

Change History

comment:1 Changed 7 years ago by Arturs Bekasovs

  • Blocking 8494 added

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Status changed from new to inprogress
  • Summary changed from [Muon] New MuonAsymmetryCalc workflow algorithm to [Muon] New MuonCalculateAsymmetry workflow algorithm

Better name.

comment:3 Changed 7 years ago by Arturs Bekasovs

Refs #8534. AsymmetryCalc: set correct Y unit label.

No need to do that manually in MuonAnalysis.

Changeset: af9693cb7baa8501fcb0dbf482bf61463fd2986a

comment:4 Changed 7 years ago by Arturs Bekasovs

Refs #8534. RemoveExpDecay: set correct Y Unit Label.

No need to do that in MuonAnalysis.

Changeset: f250883dfc289b0538f55f43a71d3af3dc7e5c69

comment:5 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Files for new MuonCalculateAsymmetry algorithm.

Changeset: fa0a29ab1882c071667b58b8be82eb6c96029f73

comment:6 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Options declaration, simplest functionality.

Changeset: be76f26d23b53bc7cc5fe1d29e7e3edf511ac56e

comment:7 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Two-period functionality.

Changeset: 952d87bd45165b2f76fb3f3d530c5f8aff771ab7

comment:8 Changed 7 years ago by Arturs Bekasovs

Refs #8534. GroupAsymmetry option support.

Changeset: 657c61af7711e6c385afe4e6725f4b9997a11829

comment:9 Changed 7 years ago by Arturs Bekasovs

Refs #8534. PairAsymmetry calculation.

Changeset: 9787ec7c91e0dc2f95c69a196ad51f2dd281fff4

comment:10 Changed 7 years ago by Arturs Bekasovs

Refs #8534. MuonCalculateAsymmetry: documentation.

Changeset: cc5158e34082c6a273a6676a90ca81ce7eb88d42

comment:11 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Merge remote-tracking branch 'origin/master' into feature/8534_muon_new_workflow_alg

Changeset: 8b88c8a9c9e5d39f194bdaa433bec7b362330643

comment:12 Changed 7 years ago by Arturs Bekasovs

Refs #8534. MuonAnalysis: new functions for calculations.

Changeset: 98e544de99d266576a44a5d5ea995716e829c0d2

comment:13 Changed 7 years ago by Arturs Bekasovs

Refs #8534. MuonAnalysis: plotSelectedItem() using new functions.

Changeset: 4201c8162040591624f4226245893fa59ef0daf1

comment:14 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Plotting on Grouping tab using new functions.

Changeset: 81a475e959fc4249a8aff0ecc3e8bad605604968

comment:15 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Removed unused functions.

Changeset: 1aecf6cdc64c968437c0c78b16f2b1f1ce3df852

comment:16 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Fixed auto-update.

Plus make sure group for every run is created when run is loaded.

Changeset: 0df90372e3f50ab8f31e9d2c04942135c2ca5488

comment:17 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Fixed re-plotting.

Changeset: 2dfd9d0d017bc07ede1fb4ea1947a901d9511a74

comment:18 Changed 7 years ago by Arturs Bekasovs

Refs #8534. More unused functions removed.

Changeset: 1564b9d6b72f20e37e95375cffe28b5a7399895e

comment:19 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Minor readability improvements.

Changeset: 05c7d3bb3cd8f345569519e7414c0be4270e1d59

comment:20 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Better error handling.

Changeset: 117a03448ea04958ccb6019fa23904c63dc8f536

comment:21 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Minor UI fix.

Problems when updating plot on focusLost(). Plus same signal was connected twice in different places.

Changeset: dd9746195a6a047c462c464e5d05fe2a99219ffc

comment:22 Changed 7 years ago by Arturs Bekasovs

Tester:

Better be somebody familiar with the Muon interface.

The task here was to move workspace calculations out of the plotGroup(), plotPair() and handlePeriods() functions of MuonAnalysis. That's so that I can use these calculations outside the interface as a workflow algorithm. Additionally, this algorithm can now be properly tested.

After that's done, I refactored MuonAnalysis code to use the new algorithm, so all the code should only run algorithms to prepare workspace, pass it to the new algorithm for processing and plot the result.

Please check that plotting still works as expected:

  1. All of the following are plotted correctly: group asymmetry,counts, log. counts and pair asymmetry.
  2. Multi-period data is handled correctly. Period arithmetic is applied.
  3. Changing binning/time values on the options tab does change the resulting plot.
  4. Workspaces created do have appropriate names and are put in the appropriate groups.
  5. Plotting of pairs/groups from the Grouping tab does work.

comment:23 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:24 Changed 7 years ago by Russell Taylor

  • Status changed from verify to reopened
  • Resolution fixed deleted

There's a GCC compiler warning that needs fixing - https://builds.sns.gov/job/ornl_clean_rhel6_develop/2595/warnings16Result/ The switch statement needs a default entry.

comment:25 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Fix compiler warning.

Switch needed a default entry.

Changeset: 509b508788d6371ae8709f9c7cc7add3f9094b39

comment:26 Changed 7 years ago by Arturs Bekasovs

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:27 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:28 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8534_muon_new_workflow_alg'

Full changeset: c205013d74429374f5fa3e80d29c2be6d4b79c47

comment:29 Changed 7 years ago by Anders Markvardsen

I have tested all of the steps 1-5 and after restructuring plotting works as before

comment:30 Changed 7 years ago by Arturs Bekasovs

Refs #8534. Initial files for new VectorColumn class.

Changeset: 68619d6c9d75f13350c7d35ea1b3d644cc4e7a30

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9378

Note: See TracTickets for help on using tickets.