Ticket #8543 (closed: fixed)
FileValidator: The call to the lowercase function object does nothing
Reported by: | Russell Taylor | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.3 |
Component: | Framework | Keywords: | student |
Cc: | Blocked By: | ||
Blocking: | Tester: | Peter Parker |
Description
...because operator() consumes the string by value.
The solution is:
(a) Something in the FileValidator constructor like:
for (auto it = extensions.begin(); it != extensions.end(); ++it) { m_extensions.insert( boost::to_lower_copy(*it) ); }
(b) Just remove the code because we seem to be doing fine without it.
Change History
comment:4 Changed 6 years ago by Dan Nixon
- Owner set to Dan Nixon
- Status changed from assigned to inprogress
comment:5 Changed 6 years ago by Dan Nixon
Added lowercase conversion for extensions
And modified unit test accordingly Refs #8543
Changeset: ad6643cb669693ab9ac74495ec3b591464769dce
comment:7 Changed 6 years ago by Dan Nixon
Used first solution to ensure all extensions are converted to lowercase.
This caused unit tests to fail when they expected "RAW" and "raw" to be two distinct extensions, such tests have been modified to represent the intended functionality (i.e. expect the size of allowedValues() to be 1 instead of 2).
comment:8 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:9 Changed 6 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:10 Changed 6 years ago by Peter Parker
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/8543_filevalidator_lowercase_fix'
Full changeset: 8e6d3987b9c115702d498dcfea41da35e06c0f5d
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9387
bulk move to assigned at the into of the triage step