Ticket #8554 (closed: fixed)
Add new version of SCD reduction scripts
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Diffraction | Keywords: | |
Cc: | lynchve@… | Blocked By: | |
Blocking: | #8565 | Tester: | Vickie Lynch |
Description
Mads worked on this to add some features. Attached are the new versions of the scripts. Here is what he said about them.
Hi all I have (finally) consolidated the different versions of Dennis’ ReduceSCD scripts that have been used. This version, called _v1, incorporates the 1D cylindrical integration (that is the output is a .profiles file) and Xiaoping’s change that allows one to load a UB file and thereby omit the FindUBUsingFFT. I had to copy/paste quite a bit – i.e. even with my extensive testing some bugs may still be there – let me know if you find some… The new files: ReduseSCD_Parallel_v1.py, ReduceSCD_OneRun.py and ReduceSCD_v1.config, can be found in /SNS/TOPAZ/shared/ReduceSCD/ I suggest we start tracking the version and copy our new changes to this folder… /Mads
Attachments
Change History
comment:1 Changed 7 years ago by Peter Peterson
- Status changed from new to inprogress
Re #8554. Mads' files with the old filenames.
Changeset: 2a3a35ee77cc51d7c25ea1c4ddc79cf7a7d49080
comment:2 Changed 7 years ago by Peter Peterson
Re #8554. Putting back in features that used to be there.
Changeset: d260e7b4e96ed5c31e301db0e2d4a1637219a8c5
comment:3 Changed 7 years ago by Peter Peterson
Re #8554. Renaming a script to match what Mads had.
Changeset: feacb52ad88592fa73e499a2080e076c68f1020e
comment:4 Changed 7 years ago by Peter Peterson
Re #8554. Finished renaming files.
Changeset: 934c434caf5607e796b259a8ff95fbb0a7728e55
comment:5 Changed 7 years ago by Peter Peterson
Re #8554. Mads gave a new version of all the scripts again.
Changeset: 7eb401ff6ccc946538d21d0bf57f8bf0b3a60f03
comment:6 Changed 7 years ago by Peter Peterson
Merge branch 'feature/8554_scd_reduce_scripts' into develop
Re #8554.
Conflicts:
Code/Mantid/scripts/SCD_Reduction/ReduceSCD_OneRun.py
Changeset: 97b81c7e6368a001f332d5e59aa9a35ca536d0e1
comment:7 Changed 7 years ago by Peter Peterson
Re #8554. Fixing line endings.
Changeset: ac6c1ece1697f1b6c9eb539af2a2d91201f9b08d
comment:8 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
This is in feature/8554_scd_reduce_scripts
To test: See if it is there with changes. Unfortunately Mads made some more changes after the initial ticket was made which you can see in comment:5.
comment:11 Changed 7 years ago by Vickie Lynch
- Status changed from verifying to reopened
- Resolution fixed deleted
Error when running only one file: python ReduceSCD_OneRun.py ReduceSCD.config 7570
Traceback (most recent call last):
File "ReduceSCD_OneRun.py", line 296, in <module>
if use_cylindrical_integration:
NameError: name 'use_cylindrical_integration' is not defined
Also do you want to change the default integration to elliptical?
comment:12 Changed 7 years ago by Peter Peterson
- Status changed from reopened to inprogress
Re #8554. Fixed bug found in testing.
Changeset: d4d7946bbfd024004925e061fbb3c89b7a37e615
comment:13 Changed 7 years ago by Peter Peterson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:16 Changed 7 years ago by Vickie Lynch
- Status changed from verifying to closed
Merge remote branch 'origin/feature/8554_scd_reduce_scripts'
Full changeset: 59fa9890fc7d3b662fd5d96f5e7fb99eb368e710
comment:17 Changed 7 years ago by Peter Peterson
Re #8554 and 8566. Fixed bug found in testing.
Cherry-picking from master.
Conflicts:
Code/Mantid/scripts/SCD_Reduction/ReduceSCD_OneRun.py
Changeset: 24a1f716759b69de19dc9d8dabd2822c55ded461
comment:18 Changed 7 years ago by Peter Peterson
Merge branch 'feature/8554_scd_reduce_scripts' into develop
Re #8554.
Conflicts:
Code/Mantid/scripts/SCD_Reduction/ReduceSCD_OneRun.py
Changeset: 97b81c7e6368a001f332d5e59aa9a35ca536d0e1
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9398