Ticket #8555 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

ISIS Live Event broken for LET & possibly others

Reported by: Martyn Gigg Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description

Trying to run the StartLiveData algorithm with LET_EVENT results in: 

Either the InstrumentName or Filename property of LoadInstrument most be specified
Error in execution of algorithm LoadInstrument:
Either the InstrumentName or Filename property of LoadInstrument most be specified to load an IDF in 
Error in execution of algorithm StartLiveData:
Either the InstrumentName or Filename property of LoadInstrument most be specified to load an IDF in

Adding g_log.debug() << "Instrument name '" << instrName << "' received from stream.\n"; to line 342 of ISISLiveEventDataListener.cpp results in a log message saying 

Instrument name '' received from stream

so it looks like either the name has not been set in the output stream or we are not reading it correctly.

Change History

comment:1 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to inprogress

ISISLiveEventDataListener tries to load instrument. If it cannot

it gives a warning and carries on. Re #8555

Changeset: 65d843e8edc126ba87bf38eede264056a1762197

comment:2 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:3 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:4 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I get a crash now when running StartLiveData with LET_EVENT and the replace method set.

comment:5 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to inprogress

Re #8555. Test received period number to be in valid range.

Changeset: 8308628fd4015cd41cc8b864e1684e6a92bfbf9a

comment:6 Changed 7 years ago by Roman Tolchenov

Re #8555. Fixing the linux builds.

Changeset: a5dd0cb32241d818cd05a3d0a0abb34935297aee

comment:7 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:8 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester changed from Martyn Gigg to Samuel Jackson

comment:9 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8555_isis_live_event_broken'

Full changeset: ​b71746f8bfa7999f7c24eb8ecee7024392f93567

comment:10 Changed 7 years ago by Samuel Jackson

Tried running with LET_EVENT and got the new warning message. Also attempted the same steps as Martyn and it no longer appears to crash.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9399

Note: See TracTickets for help on using tickets.