Crash possible in 'Send To' tab of the preferences dialog

[Russell Taylor]

Select one of the attributes of a program (e.g. target), hit edit and MantidPlot will crash. It's assuming you have the top-level tree item selected.

Also, when entering the name of the algorithm to use in the editing dialog, you get a warning log message from the AlgorithmManager for each letter typed until completion of the algorithm name. In fact, this code should call the AlgorithmFactory::exists method, which would be silent.

[Russell Taylor]

Re #8573. Avoid a crash by recursing up the tree if necessary.

Rather than just assuming it's the top level that's selected.

Changeset: a079a281305a8478a8d50441ad4ff62a64c89290

[Russell Taylor]

Re #8573. Avoid a bunch of warnings while typing algorithm name.

Just ask the algorithm factory if the algorithm exists rather than trying to create it on every keystroke (which as well as being expensive gave a warning log message until the algorithm name was complete).

Changeset: 577d7634e028b366168c022b265088b0ab1a0729

[Russell Taylor]

Testing: Just check that the issues identified in the description have been remedied.

[Michael Reuter]

Merge remote branch 'origin/bugfix/8573_sendto_crash'

Full changeset: ​99e00192b31267612f5b67aa12dc53eaf5e1dc2e

[Stuart Campbell]

This ticket has been transferred to github issue ​9417