Ticket #8584 (closed: fixed)
Refl_gui Improvements - Save different formats
Reported by: | Owen Arnold | Owned by: | Keith Brown |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.1 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | #8633 | |
Blocking: | #7377 | Tester: | Peter Parker |
Description
I'll need to help you spec this out, but the users have requested:
- Save Anso
- Save ND
- 'Custom Save' functionality as part of the save on the GUI.
Apparently Max has already written the conversion routines for us.
Attachments
Change History
comment:2 Changed 7 years ago by Keith Brown
- Status changed from new to inprogress
Refs #8584. Save methods now in separate module
SaveANSTO, saveMFT and the new saveCustom are now in a new python module. There was a brief discussion about turning them inot C++ save algorithms but it was decided we would see if they were required in the new version beofre we did that.
Changeset: 9d50b3bf85c9a3603e0f01f4fc683ac5e8f6a674
comment:3 Changed 7 years ago by Keith Brown
Refs #8584. Fixed problem in quick
A bug had slipped into quick that prevented processing. Even though it wasn't releated to this ticket it needed fixed ASAP.
Changeset: aa2ece290d1b7c21cccc86bd864428d53da19128
comment:4 Changed 7 years ago by Keith Brown
- Status changed from inprogress to verify
- Resolution set to fixed
I've sent an email to Max asking about Save ND, as i don't have code for it.
As this ticket also includes a fix for quick I'm putting this for testing, and will add Save ND in another ticket if/when max gets back to me, as the fix for quick needs to be included ASAP
To Tester
Launch the ISI Reflectonomy Gui
First check that processing works by loading a tbl file and processing it
Go file -> Save Workspaces Type in an existing directory in the top left box, and an appropriate title/prefix into the top right. double click a workspace in the left listbox to populate the right, and select a few entries in the both list boxes.
now save the selections in all available formats (custom, ANSTO, ILL Cosmos) to confirm the functionality still works.
The Save module isn't a functionality change, just a code refactoring.
comment:5 Changed 7 years ago by Keith Brown
- Summary changed from Save different formats to Refl_gui Improvements - Save different formats
Changed 7 years ago by Keith Brown
- Attachment iterdata.zip added
tbl and nxs files required for testing
comment:6 Changed 7 years ago by Keith Brown
As this was originally intended for Owen to test the files weren't included initially, but as I need anyone to test this due to the urgency of getting this in the nightly build, I've attached a zip containing the files needed to test this ticket.
comment:7 Changed 7 years ago by Peter Parker
- Status changed from verify to verifying
- Tester set to Peter Parker
comment:8 Changed 7 years ago by Peter Parker
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8584_Refl_gui_save_module'
Full changeset: 819393e861d5c21f29469330fcdc6d006c623a44
comment:9 Changed 7 years ago by Peter Parker
Save functionality still working after the refactoring.
comment:10 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9428