Ticket #86 (closed: fixed)

Opened 13 years ago

Last modified 5 years ago

Rework triple_iterator to be const correct

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Iteration 5
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

When using the current triple_iterator as a const_iterator it does not use const iterators underneath to access the workspace data. Thus the const versions of dataX. dataY etc. in the workspaces and in Histogram1D are never actually called.

Change History

comment:1 Changed 13 years ago by Russell Taylor

  • Status changed from new to assigned

comment:2 Changed 13 years ago by Russell Taylor

(In [659]) triple_iterator now uses const_iterators underneath and holds a const pointer to its workspace when it is used a const_iterator. Hence the workspace data is accessed via the const methods. You can now use const workspaces with the iterators, but there's still an issue with using the getProperty() method to assign to a const workspace. It boils down to there being no AnalysisDataService::addOrReplace method that takes a const workspace. Re #86.

comment:3 Changed 13 years ago by Nick Draper

  • Status changed from assigned to closed
  • Resolution set to fixed

comment:4 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​934

Note: See TracTickets for help on using tickets.