Ticket #8608 (closed: fixed)
INSTRUMENT_Parameters.xml no longer loaded by default
Reported by: | Anders Markvardsen | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.1 |
Component: | Framework | Keywords: | |
Cc: | owen.arnold@… | Blocked By: | |
Blocking: | Tester: | Keith Brown |
Description
- E.g. open any HRPD data say the recent HRP58468.nxs from cycle_13_4
- plot spectrum 100 and try to fit a BackToBackExponential to any peak in this spectrum. The parameters of this fitting functions (A, B and S) have not be updated according to information in HRPD_Parameters.xml (i.e. there values are 1.0, 0.05 and 1.0 respective)
- However if LoadParameterFile is used to load HRPD_Parameters.xml explicitely then the information is loaded in this file, which can be verified by repeating step 2 above a note that A, B and S are different from 1.0, 0.05 and 1.0 respectively.
I tested the following downloaded version
Most recent build as of this ticket DOES NOT WORK
Nightly build date 2nd Dec 2013 DOES NOT WORK
Stable release 3.0 DOES NOT WORK
Stable release 2.6 DOES WORK
Hence this defect has been introduced somewhere between release 2.6 and release 3.0.
Further tested that the same behaviour is observed for GEM.
As part of this ticket or as a separate ticket please add systemtest which tests that INSTRUMENT_Parameters.xml gets loaded. For example:
- Load HRPD dataset
- Adds a BackToBackExponential fitting function to fit spectrum 100
- Check that the A, B and/or S fitting parameters of this function are different from the hardcoded values, which are 1.0, 0.05 and 1.0 respectively
Attachments
Change History
comment:2 Changed 7 years ago by Anders Markvardsen
- Owner set to Anders Markvardsen
- Cc owen.arnold@… added
comment:3 Changed 7 years ago by Anders Markvardsen
Note the problem is not widespread, in more detail the problem may only be when ISIS histogram data are loaded, at least just observed that parameters are loaded for ISIS Event data
comment:4 follow-up: ↓ 6 Changed 7 years ago by Anders Markvardsen
- Priority changed from blocker to critical
Changed from blocker to critical since now identified that code has been broken just for the case of ISIS histogram nexus files, for all other cases it works, however this is still a critical bug
comment:5 Changed 7 years ago by Anders Markvardsen
- Status changed from new to inprogress
Make isis hist nexus read params again. re #8608
Changeset: f3e33dedd4ffac8a7b7b9f55099bdbe329c3644a
comment:6 in reply to: ↑ 4 Changed 7 years ago by Owen Arnold
Replying to Anders Markvardsen:
Changed from blocker to critical since now identified that code has been broken just for the case of ISIS histogram nexus files, for all other cases it works, however this is still a critical bug
I think this should be a blocker. I agree that it might not affect as many instruments as we initially thought, but we wouldn't want to release with it in this state.
comment:7 Changed 7 years ago by Anders Markvardsen
Revert "Make isis hist nexus read params again. re #8608"
This reverts commit f3e33dedd4ffac8a7b7b9f55099bdbe329c3644a.
Changeset: b2d15cf681e398a1ede3509f4e27e0c67222ee91
comment:8 Changed 7 years ago by Anders Markvardsen
Ensure sample and log loading as before. re #8608
Changeset: d01b1fa9b327ab5e8614eeb580efac15b4f0aec0
comment:9 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
To test run something like:
run1 = Load('POLREF00008481.nxs') print run1.getInstrument().getNumberParameter('LambdaMin') #Prints an empty list even though LambdaMin is definied in the POLREF_Parameters.xml file!
I.e. load any ISIS HISTOGRAM .NXS file which have an associated INST_Parameters.xml file and check that parameters are loaded.
Separate tested added for systemtest: #8704
comment:10 Changed 7 years ago by Keith Brown
- Status changed from verify to verifying
- Tester set to Keith Brown
comment:11 Changed 7 years ago by Keith Brown
Parameters are loaded. Has been checked with other parameters and instruments
comment:13 Changed 7 years ago by Keith Brown
This has been merged, but the macro didn't post here it seems
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9452
The following issue must be fixed before release