Ticket #8627 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SumEventsByLogValue needs to not fail in the presence of "ADARA phantom monitors"

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

ADARA-generated nexus files can it seems add additional non-(physically)-existent monitors into nexus files. These can cause SumEventsByLogValue to fail because it tries to look up the monitor name and finds that it doesn't exist in the instrument because it's not in the IDF (of course).

Put some defence in against this.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #8627. Catch the exception if encountering an unknown monitor.

ADARA files have been seen to occasionally contain 'phantom' monitors that aren't in the IDF. This was causing the algorithm to fail, but this change defends against that by catching the exception and then ignoring those spectra.

Changeset: 85e6e9a7617f6e77b6613e684c132548e5848ed2

comment:2 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

Can be tested with run SEQ45366 - SumEventsByLogValue (or StepScan) will fail before the changes, but not afterwards.

comment:3 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:4 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8627_SEBLV_phantom_monitor_defence'

Full changeset: ​713ea36c38bff7cb9c25dccd3e6f5a15c6e4e790

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9471

Note: See TracTickets for help on using tickets.