Ticket #863 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Mulf fitting for reflectometers

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Release 3.0
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Talk to Rob Dalgleish or Tim Charlton for details

Attachments

INTER00020681.nxs​ (659.0 KB) - added by Roman Tolchenov 7 years ago.
image001.png​ (396.3 KB) - added by Roman Tolchenov 7 years ago.
INTER_D2O_Fit_Test.py​ (1.2 KB) - added by Roman Tolchenov 7 years ago.

Change History

comment:1 Changed 11 years ago by Nick Draper

  • Owner set to Roman Tolchenov

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:7 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:10 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:11 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:12 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:13 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:14 Changed 7 years ago by Nick Draper

  • Priority changed from major to critical
  • Component set to Framework
  • Milestone changed from Backlog to Release 3.0

comment:15 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to inprogress

Added ReflectivityMulf files. Re #863.

Changeset: b79ede7c0dc97410f5f2d50733ccf2308d54cd24

comment:16 Changed 7 years ago by Roman Tolchenov

Added a unit test for ReflectivityMulf function. Re #863.

Changeset: 7838af9155489e122a6c8289e220b28d680c926d

comment:17 Changed 7 years ago by Roman Tolchenov

Fixing the Windows builds. Re #863

Changeset: 4bb210c3b1ff595d1c9acf0813030bb820446d75

comment:18 Changed 7 years ago by Roman Tolchenov

Fixing windows builds again. Re #863

Changeset: a45848e4f08b8ea6ffee9221d393b1cb56609ca5

comment:19 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Reflectometry

comment:20 Changed 7 years ago by Roman Tolchenov

More unit tests are to be written in #8187.

comment:21 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:22 Changed 7 years ago by Nick Draper

  • Status changed from verify to reopened
  • Resolution fixed deleted

Roman we need a how to test comment for this ticket otherwise no one will be able to test it.

Changed 7 years ago by Roman Tolchenov

Changed 7 years ago by Roman Tolchenov

Changed 7 years ago by Roman Tolchenov

comment:23 Changed 7 years ago by Roman Tolchenov

To tester:

  1. Download the attached files.
  2. Run the python script.
  3. Fit the first spectrum in 20681_IvsQ_binned with ReflectivityMulf.
  4. Compare the result with the one in the picture.

comment:24 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:25 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:26 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/863_reflectometry_fitting'

Full changeset: ​168cb361941451779413951c79f9bd67035e1ba6

comment:27 Changed 7 years ago by Michael Reuter

Merge remote-tracking branch 'origin/feature/863_reflectometry_fitting'

Full changeset: ​75c49585b0566863772b669d460c37c7b7b3facf

comment:28 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1711

Note: See TracTickets for help on using tickets.