Ticket #8630 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Small ReduceSCD_OneRun bug

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 3.1
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

Found by Mads:

I was looking through the ​ReduceSCD_OneRun.py script and noticed that in line 341 it says: 

if not use_ellipse_integration:

Where it should say: 

if not use_cylindrical_integration:

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Status changed from new to inprogress

Re #8630. It is actually just an 'else'

Changeset: 7677fe7f9ac4fbee02b7d73ca7e94ae5dcb5382d

comment:2 Changed 7 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Tester set to Vickie Lynch

This is on ​bugfix/8630_small_scd

To test: I suggest just looking at the change in the code.

comment:3 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester changed from Vickie Lynch to Andrei Savici

comment:4 Changed 7 years ago by Andrei Savici

Two new tickets created: #8653 to use this code in the systemtest, and #8654 to remove duplicate code

comment:5 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8630_small_scd'

Full changeset: ​fed5ed95501b5a00fa1d3fa26ae8a5fc5dbac08f

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9474

Note: See TracTickets for help on using tickets.