Ticket #8639 (closed: fixed)
Backwards compatibility for Transmission Correction
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.1 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #8643 | Tester: | Karl Palmen |
Description
I am currently in the process of converting the quick scripts into workflow algorithms, namely ReflectometryReductionOne and CreateTransmissionWorkspace. We want the users to fully move across to the new workflow algorithms, however there are a couple of problems.
1) There is currently no way to explode out the nested history from these workflow algorithms so the entirety of the workflow is hidden in the binaries (not good for prototype workflows).
2) There is no way to use some of these algorithms with the old scripts.
The first issue is a big one and will require separate attention, but a good incremental step at this point would be to do the second point. This would allow users to pass the outputs from the CreateTransmissionWorkspace into quick. This flexibility has been requested.
Attachments
Change History
comment:2 Changed 7 years ago by Owen Arnold
refs #8639. Separate make transmission corr function
Separate make transmission corr function. Utilised by existing transcorr function, but external facing. If not all arguments provided, pick them out of the IDF.
Changeset: f212bdb912f73af0ad24189131e448a5dd29e096
comment:3 Changed 7 years ago by Owen Arnold
refs #8639. Refactor out hard-coded stitching values.
This has been a long-standing problem, but is easily fixed now.
Changeset: 6717ecbd5d84398b3e15e01f2689bbd9b58464cf
comment:4 Changed 7 years ago by Owen Arnold
refs #8639. System test for new functionality.
Changeset: 15aa2d01f8b568eb01097fa73e7b504d9955cdec
comment:5 Changed 7 years ago by Owen Arnold
Tester: You must merge BOTH the mantid and system test branches called feature/8639_trans_corr_quick into their respective master branches.
If the system tests are passing on develop you are in good shape, because the new system tests check this functionality. I'm also attaching two python scripts that you should run. Both generate plots containing two curves that should be equal. In the case of one of the scripts (the one that uses CreateTransmissionWorkspace) there will be small differences between the outputs from quick.py in the curves. The reason for this is that we now do Rebin as a separate step rather than using AlignBins, which quick uses. The small differences are OK we understand them and the end-users know about them. In both scripts I am doing transmission corrections implicitly and explicitly (the new mode) and comparing the results.
comment:6 Changed 7 years ago by Owen Arnold
- Priority changed from major to critical
- Status changed from inprogress to verify
- Resolution set to fixed
- Summary changed from Separate transcorr in quick scripts to Backwards compatibility for Transmission Correction
comment:8 Changed 7 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:9 Changed 7 years ago by Karl Palmen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8639_trans_corr_quick'
Full changeset: 334b6dcce33185a9ed65fa6ebe0c8acf2f935e3e
comment:10 Changed 7 years ago by Karl Palmen
Merge remote-tracking branch 'origin/feature/8639_trans_corr_quick'
Full changeset: 9f13171c259202f2b8d098bba52c17dfd398c0ab
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9483