Ticket #8644 (closed: fixed)
Process WorkspaceIndexes
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.1 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #8656 | Tester: | Jose Borreguero |
Description (last modified by Owen Arnold) (diff)
Need an algorithm that can pre-process workspace index list operations. The syntax must be similar to that listed here. http://www.mantidproject.org/MultiFileLoading. This will involve interpreting a string input property as well as an input workspace and returning a cropped/summed resulting workspace according to the string input. This should probably be a workflow algorithm.
Change History
comment:3 Changed 7 years ago by Owen Arnold
- Status changed from new to inprogress
refs #8644. New indexing workflow algorithm
Changeset: df266877e487256fd29946e1e5eea70fe582776c
comment:4 Changed 7 years ago by Owen Arnold
refs #8644. Move to command based design.
Changeset: 7d2e378c70e00188ab9be7010fd5b01a4e81e5e8
comment:5 Changed 7 years ago by Owen Arnold
refs #8644. Bring in other command types.
One issue yet to resolve is that we must keep the order of the operations the same as has been provided in the parameter arguments.
Changeset: 2de35b4b1bc0d8242c3e5a01f64700e2921824ea
comment:6 Changed 7 years ago by Owen Arnold
refs #8644. Do operations in order correct order.
Changeset: a907e83a006bea4a34b09f8479fea7dd6858e9f9
comment:7 Changed 7 years ago by Owen Arnold
refs #8644. Fix tests now that isValid is used.
Changeset: a749441a25dd921541a95b413da2d716498ede6a
comment:8 Changed 7 years ago by Owen Arnold
refs #8644. Extract to method for interpreter steps.
Changeset: a529b2317c29d0a94f37c8450481a2c77945bf8a
comment:9 Changed 7 years ago by Owen Arnold
refs #8644. Extend tests and add documentation.
Changeset: 0c4efde9d172031440128e86c44f21d89a26bfdf
comment:10 Changed 7 years ago by Owen Arnold
refs #8644. Fix compiler warnings.
Changeset: e7bf0f57a8bd03200a2e20b575ec94da92da9112
comment:11 Changed 7 years ago by Owen Arnold
- Description modified (diff)
- Blocked By 8647 removed
- Summary changed from ReflectometryReductionOne WorkspaceIndexes to Process WorkspaceIndexes
comment:12 Changed 7 years ago by Owen Arnold
Tester: Here is a demonstration of this working. See unit tests for more examples.
inws = CreateWorkspace(DataX=[0,1], DataY=[1,2,3,4,5], NSpec=5) outws = PerformIndexOperations(InputWorkspace=inws, ProcessingInstructions="0-4") # Sum all bins print outws.getNumberHistograms() print outws.readY(0)[0] # Should be 15
comment:13 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:14 Changed 7 years ago by Owen Arnold
- Status changed from verify to reopened
- Resolution fixed deleted
comment:15 Changed 7 years ago by Owen Arnold
- Status changed from reopened to inprogress
refs #8644. Add when spectra are not neighbours.
Changeset: 72f38658fc516141d370c3c7a4489037d4b3927a
comment:16 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:17 Changed 7 years ago by Jose Borreguero
Hi Owen, I tried to look at your test with "git test start" but it seems it hasn't been fully merged in develop:
mantid> git test start 8644 git fetch -p ERROR: Branch 'feature/8644_workspace_index_operations' has not been fully merged to develop, meaning it is not possible to know whether the code is valid on all environments. Contact Owen Arnold on owen.arnold@stfc.ac.uk (or via skype) and ask them to merge the code to develop using 'git checkbuild' from their branch feature/8644_workspace_index_operations and let you know when it passes testing on the buildservers so you can start testing.
comment:18 Changed 7 years ago by Owen Arnold
Should all be up to date now.
comment:20 Changed 7 years ago by Jose Borreguero
- Status changed from verify to verifying
- Tester set to Jose Borreguero
comment:21 Changed 7 years ago by Jose Borreguero
I tried the selections outlined in http://www.mantidproject.org/MultiFileLoading. The following selections worked as expected: "0:3", "0-3", "0,1,2", "0+1", "1+2,0". The following selections did not work: "0:4:2", "0-4:2". Did you implement these type of selections?
comment:22 Changed 7 years ago by Owen Arnold
No this is not implemented and will not be. The wiki documentation (top of the ccp file) lists exactly what is supported and what is not.
comment:23 Changed 7 years ago by Jose Borreguero
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8644_workspace_index_operations'
Full changeset: 0e26de6a56fa31c4513ce18463d750dc4a88692d
comment:24 Changed 7 years ago by Jose Borreguero
Works fine
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9488