Ticket #8648 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

If one tries to generate history from old nxs workspace and some algorithms used to build this workspace are removed, the history can not be generated.

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.1
Component: Framework Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: Tester: Andrei Savici

Description

Start Matid 3.0 (or later) and load MARIReduction.nxs (from System tests reference results)

Open "show history" and try "Script To clipboard" (or to file).

Action fails as FlatBackground is not registered any more (Calculate FlatBackground is in Mantid instead)

We need to be able to generate history for old workspaces which contain deprecated/missing algorithms

Change History

comment:1 Changed 7 years ago by Alex Buts

  • Status changed from new to inprogress

refs #8648 This should fix it

The missing algorithm does not throw the history but prints the contents of the missing algorithm.

Changeset: ec71fa4a7d0ca777ddca2ea7dc0da561c8194fcc

comment:2 Changed 7 years ago by Alex Buts

  • Milestone changed from Backlog to Release 3.1

comment:3 Changed 7 years ago by Alex Buts

  • Status changed from inprogress to verify
  • Owner set to Alex Buts
  • Resolution set to fixed

It is not a very smart solution, but I think is the reasonable one as anything else would request huge efforts and changes in framework.

If an algorithm is not registered with Mantid any more, GeneratePythonScript does not fails but prints the old algorithm signature and properties which would allow user to recover the algorithm contents.

After this fix tester should be able to generate history from MARIReduction.nxs which is failing now and look at the history to be able to recover the properties of the FlatBackground algorithm which does not exist any more. (until I have changed MARIReduction.nxs for another ticket.)

comment:4 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:5 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8648_missingAlgoHistory'

Full changeset: b3bda0928ac4567ea5ab3af1f9afeccc5db2b3e8

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9492

Note: See TracTickets for help on using tickets.