Ticket #8669 (closed: fixed)
AddSampleLog needs to be able to create integer-type time series logs
Reported by: | Russell Taylor | Owned by: | Russell Taylor |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #8637 | Tester: | Michael Reuter |
Description
This is needed for #8637 as SumEventsByLogValue needs to be given a integer TimeSeriesProperty in this scenario. Right now AddSampleLog always creates a double TSP if asked to create a time-series. Modify this so that it creates an int TSP if an integer value is passed in.
Change History
comment:2 Changed 7 years ago by Russell Taylor
- Status changed from new to inprogress
Re #8669. Create an integer-typed log if appropriate.
If the value passed in can be converted to an integer then create a PropertyWithValue<int> or TimeSeriesProperty<int> for the 'Number' & 'Number Series' options respectively.
Changeset: 22dbb6e177301ccf4075824742ebbb98ecdeafcc
comment:3 Changed 7 years ago by Russell Taylor
Re #8669. Add a test for the creation of integer-typed logs.
Changeset: 4a9ea9da4a1f218b8a3d71c2714b8ad2f91720e7
comment:4 Changed 7 years ago by Russell Taylor
Re #8669. Update the wiki documentation.
Changeset: c456490f6d77a61760632e59a823de2816039572
comment:5 Changed 7 years ago by Russell Taylor
Re #8669. Fix tests by ensuring log is created as a double.
Changeset: 25cf6a53b753fccc1c574e04eabae5e9aaeb885d
comment:6 Changed 7 years ago by Russell Taylor
Re #8669. Make sure logs are created as doubles.
Changeset: b0920fd403e6ffa52e203f60ee4554be41c621c8
comment:7 Changed 7 years ago by Russell Taylor
Re #8669. Make sure logs are created as doubles.
Changeset: e6063355aeb6d993aa4da3dbbd7cd475a7df7639
comment:8 Changed 7 years ago by Russell Taylor
Re #8669. Make sure logs are created as doubles.
Changeset: 56e1d33300f53a697ab56d78095d8cc46b305f5a
comment:9 Changed 7 years ago by Russell Taylor
Re #8669. Update docs to show doubles being passed.
Changeset: 131d2bfbf14fffa46cf2906f3c052a4170f80232
comment:10 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
To test, add a bunch of logs to some workspace, giving some an integer and some a floating point number both for the "Number" and "Number Series" options. Then check they're of the correct type using the script interpreter:
r = ws.getRun() In [3]: print r.getLogData("int") <mantid.kernel._kernel.PropertyWithValue_int object at 0x12e145c20> In [4]: print r.getLogData("dbl") <mantid.kernel._kernel.PropertyWithValue_double object at 0x12e145a60> In [5]: print r.getLogData("dblseries") <mantid.kernel._kernel.FloatTimeSeriesProperty object at 0x12e145ad0> In [6]: print r.getLogData("intseries") <mantid.kernel._kernel.Int32TimeSeriesProperty object at 0x12e145e50>
comment:11 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:12 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8669_addsamplelog_int_properties'
Full changeset: a03746b83f2aef2f0a24f18229141bcca9041c3a
comment:13 Changed 7 years ago by Michael Reuter
Merge remote-tracking branch 'origin/feature/8669_addsamplelog_int_properties'
Full changeset: 0818b7ecce15b8d56342c8fcb4daf04a8097eea9
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9513