Ticket #8678 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

MUON: cannot plot from result table

Reported by: Anders Markvardsen Owned by: Arturs Bekasovs
Priority: critical Milestone: Release 3.1
Component: Muon Keywords:
Cc: adrian.hillier@… Blocked By:
Blocking: Tester: Samuel Jackson

Description (last modified by Arturs Bekasovs) (diff)

  1. Do sequential fit of MUSR15189-15199.
  1. Open Results Table and create table selecting Run Number, CountRate and Field_Danfysik.
  1. In the table, select any Y column and CountRate column. A correct plot gets created.
  1. Select any Y column, CountRate column and Run Number column. Plot is empty.
  1. Select any Y column and Field_Danfysik column. Plot is empty again.

Change History

comment:1 Changed 7 years ago by Arturs Bekasovs

Wasn't able to reproduce it. After doing what is described in 4. the plot does get created.

comment:2 Changed 7 years ago by Arturs Bekasovs

With a bit of help from Anders was able to reproduce the problem. It appears when we have both X and L columns in the table.

comment:3 Changed 7 years ago by Arturs Bekasovs

  • Status changed from new to inprogress

Refs #8678. Fixed and refactored addCurves method.

Y column are now added to the beginning of the list of drawable columns so that they are drawn first and can be later found to attach error and label columns to.

Switch statement is used now instead of a bulk of ifs.

Changeset: d6b9583c6af7b0654598dc347158d2f03ca480c6

comment:4 Changed 7 years ago by Arturs Bekasovs

Refs #8678. Fixed colIndex method.

It was assuming that column names shouldn't have underscores in them, which was not always true. A bit cleverer approach is now used.

Changeset: 1a90918c5cfda395ade0c116952f6d0d0297851d

comment:5 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

Tester:

There were two main problems causing the described scenario to happen:

  1. Nothing was being drawn when we had column with plot type Label.

  1. Column have not been used when it had underscores in its name, e.g. Field_Danfysik.

So the task is to check that those problems were fixed. Follow the described steps and make sure plot in 4. does have Run Numbers as labels and plot in 5. uses Field_Danfysik as X.

comment:6 Changed 7 years ago by Arturs Bekasovs

  • Description modified (diff)

comment:7 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:8 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8678_table_plotting'

Full changeset: 94efe63112a36849112ab4c6c570379d9ebf27cd

comment:9 Changed 7 years ago by Samuel Jackson

Checked changes have fixed the listed issues. Code code changes look good too.

comment:10 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Muon

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9522

Note: See TracTickets for help on using tickets.