Ticket #8689 (closed: fixed)
Fix l2q systemtest failures
Reported by: | Andrei Savici | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | major | Milestone: | Release 3.1 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Russell Taylor |
Description
Since the change in l2q signature, the L2Qscript test fails. The following lines should be changed:
- in mantid/Code/Mantid/scripts/Reflectometry/isis_reflectometry/l2q.py the comment on line 10
- in mantid/Code/Mantid/scripts/Reflectometry/isis_reflectometry/quick.py line 150
- in systemtests/SystemTests/AnalysisTests/L2QScriptTest.py line 17
Change History
comment:2 Changed 7 years ago by Owen Arnold
Apologies, and thanks for highlighting this Andrei. I shouldn't have let this get to develop.
comment:3 Changed 7 years ago by Owen Arnold
refs #8689. Fixes L2QTest.
Changeset: 7e1567340e1774729addad027a999d938fe0efac
comment:4 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
System tests should now be fixed. L2Q system tests on develop should run before passing this ticket.
comment:5 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
Merge remote branch 'origin/feature/8689_fix_system_tests'
Full changeset: b86a2542baa8974bf3f43fdfbe43e100063701d9
comment:7 Changed 7 years ago by Russell Taylor
- Status changed from closed to reopened
- Resolution fixed deleted
I've merged the system test change in to get that passing, but I'm re-opening because Andrei is correct about the places in the mantid repository that need changing.
comment:8 Changed 7 years ago by Owen Arnold
- Status changed from reopened to inprogress
refs #8689. Fix l2q usage and documentation.
Changeset: 446140a07565d70c8d88caf4593a4e325e5976df
comment:9 Changed 7 years ago by Owen Arnold
Tester:
Running the following should result in a log information message from l2q indicating that detector positions are being corrected.
from isis_reflectometry import quick reload(quick) from isis_reflectometry import l2q reload(l2q) workspace_name = "POLREF4699" workspace_nexus_file = workspace_name + ".nxs" ws = Load(workspace_nexus_file, OutputWorkspace=workspace_name) first_ws = ws[0] quick.quick_explicit(first_ws, i0_monitor_index=0, lambda_min=0.8, lambda_max=14.5, background_min=0.8, background_max=14.5, int_min=0.8, int_max=14.5, point_detector_start=0, point_detector_stop=245, multi_detector_start=1, correct_positions=True, theta=0.4, pointdet=False, roi=[74,74], detector_component_name='lineardetector', sample_component_name='some-surface-holder')
comment:10 Changed 7 years ago by Owen Arnold
Changes here affect both the mantid and system test repositories
comment:11 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:13 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
Merge remote branch 'origin/feature/8689_l2q_issues'
Full changeset: 1bd0029a1ff6787495367dffa1999d972619e86e
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9533