Ticket #8698 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Delete key should delete workspaces when selected in the GUI

Reported by: Martyn Gigg Owned by: John Hill
Priority: major Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Raquel Alvarez Banos

Description (last modified by John Hill) (diff)

On the recent training course I noticed that the keyboard ‘delete’ key does not work if you select a workspace in the ‘Workspaces’ window. Arrow keys work to change selection, but you need to click the ‘Delete’ button. I found it unintuitive not to be able to delete a workspace with the keyboard delete key.

Testing:

•Check that the delete key works to delete selected workspaces or an open matrix workspace if it is the active window.

•Check that the delete key still works for other actions around Mantid.

•Check that the confirmation prompt shows and that the preference can be set to supress it.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Component changed from Framework to User Interface

comment:2 Changed 7 years ago by Russell Taylor

Seems reasonable, but I think there should be a confirmation dialog for this, in case of accidental key-hitting. In fact, it might be worth having this on the existing button. It could have a "Don't show this again" option, backed by a preference setting.

There's also a small issue of there being no visual clue as to whether this widget has focus.

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:4 Changed 6 years ago by John Hill

  • Owner set to John Hill

comment:5 Changed 6 years ago by John Hill

  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.3

Delete key will perform the action of the delete button.

Added a delete confirmation prompt when deleting with a preference option under General->Confirmations to suppress the prompt; the prompt is enabled by default.

comment:6 Changed 6 years ago by John Hill

  • Status changed from assigned to inprogress

Refs #8698 adding delete key shortcut and confirmation prompt

Changeset: 9106dc568aa29197b3388bd24aade3817e8ee3fe

comment:7 Changed 6 years ago by John Hill

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:8 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez Banos

comment:9 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to closed

comment:10 Changed 6 years ago by Raquel Alvarez Banos

Merge remote-tracking branch 'origin/feature/8698_delete_key'

Full changeset: 6205597870c2b88de6b847e6728cc509c451cabf

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9542

Note: See TracTickets for help on using tickets.