Ticket #8728 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Make a use of EXPORT_OPT_MANTID_ICAT macro

Reported by: Arturs Bekasovs Owned by: Jay Rainey
Priority: minor Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

EXPORT_OPT_MANTID_ICAT macro defined in ICatExport.h might be used instead of DLLExport for all the ICat classes. This might provide a better optimization potential on Windows and seems to be more consistent.

Change History

comment:1 Changed 7 years ago by Jay Rainey

  • Summary changed from [ICAT] Make a use of EXPORT_OPT_MANTID_ICAT macro to Make a use of EXPORT_OPT_MANTID_ICAT macro

comment:2 Changed 7 years ago by Jay Rainey

  • Milestone changed from Backlog to Release 3.2

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:4 Changed 7 years ago by Jay Rainey

  • Status changed from assigned to inprogress

Remove unused DLL Export file. Refs #8728.

Changeset: 774dc6007954568aab8f34b1d36137061e9ea76e

comment:5 Changed 7 years ago by Jay Rainey

Added new DLLConfig file for ICAT. Refs #8728.

Changeset: 3de2e54fc96d2da8bbecfe0d9e1b3ead5f07cfd2

comment:6 Changed 7 years ago by Jay Rainey

Use correct export in catalog algorithms. Refs #8728.

Changeset: ee5bf41e06858b450bdd1049cbe1da903faa8493

comment:7 Changed 7 years ago by Jay Rainey

Merge branch 'feature/8728_icat_import_consistency' into develop

Changeset: f86b83619340c348b8a0cbc653355e2c733f9038

Last edited 7 years ago by Jay Rainey (previous) (diff)

comment:8 Changed 7 years ago by Jay Rainey

  • Status changed from inprogress to verify
  • Resolution set to fixed

This was a minor consistency change that dealt changing DLLExport in the catalog algorithms to MANTID_ICAT_DLL.

To test

Test by code review to ensure the catalog algorithms (​listed here) now make use of the new DLLConfig macro. (see: ​this commit).

comment:9 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:10 Changed 7 years ago by Martyn Gigg

This is me being very picky but could we use lower case Ls in the filename, i.e. DllConfig.h. It's more consistent with all of the others in the framework then.

comment:11 Changed 7 years ago by Jay Rainey

Rename DLLConfig to Dllconfig. Refs #8728.

Changeset: 0bf44a48d4c153e02187660174d9c6f005bd2f64

comment:12 Changed 7 years ago by Jay Rainey

Merge branch 'feature/8728_icat_import_consistency' into develop

  • feature/8728_icat_import_consistency: Rename DLLConfig to Dllconfig. Refs #8728.

Changeset: 1719fc71b552cbd8430a23769851e472856b71b3

comment:13 Changed 6 years ago by Nick Draper

  • Status changed from verifying to verify
  • Tester Martyn Gigg deleted

comment:14 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:15 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8728_icat_import_consistency'

Full changeset: ​a7b0192001d16f87f32e8283134bb1b30cadc8e5

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9572

Note: See TracTickets for help on using tickets.