Ticket #8748 (closed: fixed)
Fix ImportMDEventWorkspace
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | |
| Cc: | saviciat@… | Blocked By: | |
| Blocking: | Tester: | Andrei Savici |
Description
Reported by Andrei. ImportMDEventWorkspace crashes out with the attached file. The problem is that the way it determines the type of event being loaded (Full MDEvent or LeanMDEvent) is not robust enough and the logic can get confused.
For the main block of the data, we need to know how many columns there are.
Attachments
Change History
comment:1 Changed 7 years ago by Owen Arnold
- Status changed from new to inprogress
refs #8748. Fix made to ImportMDEventWorkspace.
Tests also updated. We explicitly look at the number of columns in the data block rather than trying to infer it. This is where it was going wrong before.
Changeset: 804c5d6859acf766af33452f9c14a2f94f9210f8
comment:2 Changed 7 years ago by Owen Arnold
refs #8748. Removed unused variable.
Changeset: 48771b1769eb75d24703d3f97501d829ddbf48bd
comment:3 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
Tester. Take the attached txt file and pass to ImportMDEventWorkspace. It should produce a MDWorkspace of 2D MDLeanEvents. Doing this in the current version of mantid will cause a crash should be fixed with these changes.
comment:4 Changed 7 years ago by Andrei Savici
- Status changed from verify to verifying
- Tester set to Andrei Savici
comment:5 Changed 7 years ago by Andrei Savici
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8748_import_md_event_fix'
Full changeset: d3825114e02f81391e2c52f10a6a871fa14d519d
