Ticket #8776 (closed: fixed)
Custom Dead Times field not hidden when auto-reset correction type
| Reported by: | Arturs Bekasovs | Owned by: | Arturs Bekasovs |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1 |
| Component: | Muon | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Jay Rainey |
Description
To reproduce:
- Open MuonAnalysis interface.
- Set Dead Time Correction type to From Disk.
- Set appeared file input to a random file which does not containt dead times.
- Load any Muon data file.
A warning is shown and Dead Time Correction type is reset to None. Though the custom file is not hidden in the way it would be if you set it to None manually.
Attachments
Change History
comment:2 Changed 7 years ago by Arturs Bekasovs
Refs #8776. Improve error handling a bit.
Changeset: 2170830ddcbd4879c285fae970a324df1a65b277
comment:3 Changed 7 years ago by Arturs Bekasovs
Tester:
First, please check that the described scenario doesn't happen anymore.
Second, check these simple use cases:
- Setting the dead time correction type to "From Disk" shows the file input widget and setting it to any other type, hides it.
- If auto-update is enabled, the plot is updated when we set dead time correction type to "None", "From Data File" or select a file with custom dead times. You can use the attached file with dead times (it is completely artificial so that you can notice the difference on the plot, don't be surprised by the results) and AutoTestData/emu00006473.nxs.
Changed 7 years ago by Arturs Bekasovs
- Attachment dead_times_32.nxs added
Single value dead times for 32 detector instrument
comment:4 Changed 7 years ago by Arturs Bekasovs
- Status changed from inprogress to verify
- Resolution set to fixed
comment:5 Changed 7 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:6 Changed 7 years ago by Jay Rainey
- Status changed from verifying to closed
I used a recent master clean build to verify what the problem was, including using the test cases mentioned in comment:3. I then built the branch locally to verify the changes made solve this issue, which they do. The code is clean, logical, and well-written.
comment:7 Changed 7 years ago by Jay Rainey
Merge remote-tracking branch 'origin/bugfix/8776_muon_dead_times_field_not_hidden'
Full changeset: d1969df35dfb593f25f602893d5fe5dc051d7104
Refs #8776. Split signal for any change and auto-update.
We need to show/hide custom data file widget no matter whether the value was changed programmatically or by user, but auto-update only if the value was changed by user. So I've split the functionality into two parts.
Changeset: b633249c1b9bad63019dbb1541cc7d9b99596df9