Ticket #8780 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Quick should co-add

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 3.1
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #8783 Tester: Keith Brown

Description

While we are still using the quick script (hopefully not for much longer). We need to ensure that the co-add features (read sum-spectra) are accessible. Traditionally this has been done using a colon to separate runs which are to be co-added prior to processing. We need to add the ability to specify comma and colon separated runs as an argument to quick.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

refs #8780. Add ability to coadd via commas and colons

Changeset: 34e79c21a52fa8aedbd908a70148da5a48754e1c

comment:2 Changed 7 years ago by Owen Arnold

Tester: The following shows the effect of coadding runs. All you need to verify is that the two lines on the plots that are produced are different.

from isis_reflectometry.quick import *
config['default.instrument'] = 'INTER'
LoadISISNexus(Filename='13460', OutputWorkspace='13460')
LoadISISNexus(Filename='13464', OutputWorkspace='13464')
 
quick(run='13460', theta=0.7)
one = CloneWorkspace('13460_IvsLam')

quick(run='13460, 13464', theta=0.7)
two = CloneWorkspace('13460_IvsLam')

plotSpectrum([one, two], 0)

I have added unit tests for the splitting. You should also verify that There are sufficient system tests for the existing functionality of this script, so make sure the system tests are passing.

comment:3 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:4 Changed 7 years ago by Keith Brown

  • Status changed from verify to verifying
  • Tester set to Keith Brown

comment:5 Changed 7 years ago by Owen Arnold

  • Blocking 8783 added

(In #8783) Your fix af99d3bb61a869984ba9ab98f1577c2c0fa39f0b is only develop, not on your feature branch. The correct thing to do is to set #8780 as a blocker to this ticket, and then merge master into this branch once that ticket has passed. That way you can apply your changset again, and everything should work nicely.

comment:6 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Keith has reported failures with this functionality.

comment:7 Changed 7 years ago by Owen Arnold

Tester. This should produce the same results as the above example where a comma is used.

from isis_reflectometry.quick import *
config['default.instrument'] = 'INTER'
LoadISISNexus(Filename='13460', OutputWorkspace='13460')
LoadISISNexus(Filename='13464', OutputWorkspace='13464')
 
quick(run='13460', theta=0.7)
one = CloneWorkspace('13460_IvsLam')

quick(run='13460:13464', theta=0.7)
two = CloneWorkspace('13460_IvsLam')

plotSpectrum([one, two], 0)

comment:8 Changed 7 years ago by Owen Arnold

  • Status changed from reopened to inprogress

refs #8780. regex splitting needs extending

Changeset: 4e6837d1632138377edf4f6e6a03b1e5a2bf8906

comment:9 Changed 7 years ago by Owen Arnold

refs #8780. Merge branch 'feature/8780_coadd_in_quick' into develop

Conflicts:

Code/Mantid/scripts/Reflectometry/isis_reflectometry/convert_to_wavelength.py

Changeset: a06c037df382635049c095d023c26afe7e23459d

comment:10 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

Unit tests and system tests checked. Should be working fine now.

comment:11 Changed 7 years ago by Keith Brown

  • Status changed from verify to verifying

comment:12 Changed 7 years ago by Keith Brown

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8780_coadd_in_quick'

Full changeset: 20d169175c06f8782e3f333f55f404dc37407291

comment:13 Changed 7 years ago by Keith Brown

Works with colons now

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9624

Note: See TracTickets for help on using tickets.