CRISP and Reflectometry GUI

[Owen Arnold]

The attached screenshot shows this failing.

Here's my theory: Having a look at the error, I suspect this is because the IDF parameters you have updated are not quite correct. It was only the polarisation constants that should have been copied over from POLREF, not all the other parameters, and the old values have been left in the IDF, so we have duplicates. The parameter file overwrites those in the IDF, so the offsets and instrument specifics will be wrong for CRISP.

Here's what I'd like you to do (In order)

1) Reproduce the error Max is seeing. Use the screenshot attached. If you have problems getting hold of the data, I can help you with that.

2) Following my theory above, ensure that the correct parameters are moved over from the CRISP IDF into the Parameter file. Rerun the test above, the problem should go away.

3) If (2) works, delete out the parameters from the CRISP IDF now that the correct ones are in the parameter file.

4) Search through the remaining instruments to make sure that we do not have duplicate parameters between the IDF and parameter file.

[Keith Brown]

Make sure the "correction" parameter is present in all instruments and in the parameters file

[Keith Brown]

same for "polystring"

[Keith Brown]

This script will reproduce the fault with the old IDF and parameter files

\systemtests\Data\ needs to eb in your managed user directories.

from isis_reflectometry import quick
Load(CSP85423.nxs)
quick.quick(mtd["CSP85423_1"],theta=0.1)

[Keith Brown]

Refs #8788 IDF fixes for Reflectometry Instruments

CRISP has now had its own parameters put in its parameters file. It has had a correction specifier of none added, as it had no type defined.

INTER and SURF have had thier correction parameters moved across to their parameter files.

EOL characters have been added to the end of files which didn't have them before.

Changeset: c29020a0e31af3054a129d2672559ec0357869ef

[Keith Brown]

No system tests failed, so this is clear to test

To Tester

Make sure all the features of the Reflectometry gui still work. General use instructions - http://www.mantidproject.org/ISIS_Reflectometry_GUI Testing instructions - http://www.mantidproject.org/Testing_ISIS_Reflectometry_GUI Example - http://www.mantidproject.org/ISIS_Reflectometry_Examples

Run the script above, it shouldn't produce any errors

CRISP should have a correction of None in it's parameters file and the polystring, C0 and C1 parameters shouldn't be there

INTER and POLREF should have a correction of polynomial in it's parameters file, polystring should be present, C0 and C1 parameters shouldn't be there

SURF should have a correction of exponential in it's parameters file, C0 and C1 should be present and the polystring parameter shouldn't be there

[Keith Brown]

(In #7377) There are no code changes against this ticket, this was grouping all the work done to it. Build a fresh copy of master to test this.

To Tester

Go through each of the tickets that were blocking this one and make sure their fixes haven't been broken by subsequent tickets.

Make sure all the features of the Reflectometry gui still work as per these docs.

• General use instructions - http://www.mantidproject.org/ISIS_Reflectometry_GUI
• Testing instructions - http://www.mantidproject.org/Testing_ISIS_Reflectometry_GUI
• Example - http://www.mantidproject.org/ISIS_Reflectometry_Examples

Note that there are some features that we know don't work and will be fixed up next release. #8814 was opened to deal with a type problem The 3-column export format hasn't been implemented Spectra list definition when exporting hasn't been implemented

[Keith Brown]

Should still block #7377

[Owen Arnold]

This isn't blocked by 7377, (although it may be blocking 7377) as 7377 is blocked by 8787, which has nothing to do with this feature.

[Keith Brown]

Yeah, my mistake, but the number in the wrong blocker field

[Owen Arnold]

I'm getting errors internally from quick when running the python example. I'm hoping that changes made in 8733 (pending testing) will shake these out.

[Owen Arnold]

Not sure what change in master has cased this, but no longer getting errors running the script example.

[Owen Arnold]

Merge remote-tracking branch 'origin/bugfix/8788_CRISP_IDF_parameters'

Full changeset: ​150499fa02eecb5e21f9f680027edf3c5b1c3e25

[Stuart Campbell]

This ticket has been transferred to github issue ​9632