Ticket #8798 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

ConvFit output needs to be interleaved.

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.1
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description

ConvFit is currently outputting all Amplitudes, then all widths then Height. It should output:

Height
Amplitude
FWHM
Amplitude
FWHM

While I don't believe this actually breaks anything, it should be consistent with other fitting routines.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8798 Change ConvFit to output fit parameters in correct format.

This change will only be noticeable when uisng two Lorentzians.

Changeset: d047ffa6d72cc49f050937c74f417b4d0bd3091a

comment:2 Changed 7 years ago by Samuel Jackson

  • Milestone changed from Backlog to Release 3.1

comment:3 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

This ticket should be tested thoroughly to test all code paths. As a minimum you should try running a sequential convfit with:

  • A single Lorentzian
  • Two Lorentzians
  • One Lorentzian and a delta function
  • Two Lorentzians and a delta function

And check that the output is ordered as described in the ticket description. When using a delta function you should see one entry for the height which is the first spectrum and then one entry for the EISF for each peak, so for two peaks it would look something like the following:

Height
Amp
FWHM
EISF
Amp
FWHM
EISF

For further information on running the ConvFit interface see: http://www.mantidproject.org/Indirect:Indirect_Data_Analysis#Running_ConvFit

comment:4 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:5 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8798_convfit_fit_output'

Full changeset: 1b7a1c7c85c63668ed43152409b8a23d6437117b

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9642

Note: See TracTickets for help on using tickets.