Ticket #8819 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Indirect C2E: Spectra min/max is inconsistent

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: minor Milestone: Release 3.2
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Arturs Bekasovs

Description

I found the following issues with these options:

  • Setting either to be a number < 0 causes python ValueErrors
  • Setting an invalid range (max < min) causes a message box to be displayed
  • Setting the upper bound to be higher than the no. spectra throws a cropping error.

As there appears to be support for showing a message box, we should use this for displaying errors where we can.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

  • Status changed from new to inprogress

Refs #8819 Add check to interface for values less than 1.

Changeset: d85ec795ccac38f37944821ac538af51ca5e0885

comment:2 Changed 7 years ago by Samuel Jackson

Refs #8819 Throw more verbose error during reduction.

Changeset: f275a83dbd752d0055234f2eff393e1c15af8e2a

comment:3 Changed 7 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

I've done my best here. Where I can I've displayed a user error using a message box rather than the results log. However, I do not know in advance how many spectra the file will have, so have just added a more verbose error description.

Run through an indirect energy conversion and check that setting spectrum min/max is more consistent in the errors shown.

comment:4 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:5 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:6 Changed 7 years ago by Samuel Jackson

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:7 Changed 7 years ago by Arturs Bekasovs

  • Status changed from verify to verifying
  • Tester changed from Jay Rainey to Arturs Bekasovs

comment:8 Changed 7 years ago by Arturs Bekasovs

Error consistency was improved - obvious errors such as max < min and min/max < 1 are reported as expected. Out of range max is spotted only after the converting process begins, but the Python error message is self-explanatory. I don't see a way to do it better.

comment:9 Changed 7 years ago by Arturs Bekasovs

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8819_c2e_spec_min_max'

Full changeset: e8f39c65c3b0af2f325a7f13ab36e575326e6b7c

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9664

Note: See TracTickets for help on using tickets.