Ticket #8855 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Crash using Guess Alpha in Muon Interface

Reported by: Peter Parker Owned by: Arturs Bekasovs
Priority: major Milestone: Release 3.2
Component: Muon Keywords: Windows
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Loading the current run of EMU and HIFI on what was a relatively fresh install of Mantid, and then trying to "Guess Alpha" resulted in a crash. Unfortunately I can no longer reproduce the error -- perhaps since I've loaded a file that Guess Alpha seems to work fine for.

Arturs, as we discussed, this might take a bit of playing around with to try and reproduce the error. If you can't reproduce it give me a shout and I'll give it another go.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Keywords Windows added

Loading the current run works on Windows only.

comment:3 Changed 7 years ago by Arturs Bekasovs

Tried to reproduce using various instruments and pair sets - wasn't able to.

Peter, could you try it again?

comment:4 Changed 7 years ago by Peter Parker

I was unable to reproduce, so if you can't either then feel free to close. We can come back to this if we see it again.

comment:5 Changed 7 years ago by Arturs Bekasovs

  • Status changed from assigned to inprogress

After the code inspection, I've managed to come up with two cases when the unhandled exception is thrown:

  1. FirstGoodData box is empty. It seems to be checked for empty value when plotting, but not when being passed to AlphaCalc algorithm.
  2. MuonAnalysis workspace is deleted before clicking "Guess Alpha".

I will fix those in this ticket.

comment:6 Changed 7 years ago by Arturs Bekasovs

Refs #8855. Check first good bin value on every access.

Reset it to default if empty/invalid value is specified and output the appropriate warning.

Changeset: 43dd24141ee104b18b422f875e9b517a6c7c08e5

comment:7 Changed 7 years ago by Arturs Bekasovs

Refs #8855. Refactor plotFromTime and plotToTime.

ploFromTime now uses firstGoodData() to avoid checking/resetting the value in two plaves. Both plotFromTime and plotToTime now behave in the same way firstGoodData() does.

Changeset: 630be3fddd26da08cf6e82b8f5c6d5b72564ca18

comment:8 Changed 7 years ago by Arturs Bekasovs

Refs #8855. Catch exceptions from AlphaCalc.

Changeset: 481680a8c92a56350c646e3d9c1833333bb71567

comment:9 Changed 7 years ago by Arturs Bekasovs

Tester:

Check that the problems described in comment:6 are not happening any more:

  1. Leave First Good Data box on the Home tab empty, and try to use Guess Alpha and plot. Appropriate error should be printed to log and value reset to default.
  1. Delete MuonAnalysis and verify that pressing Guess Alpha is showing appropriate error. Then load some new data so that MuonAnalysis is re-created and verify that the interface is functional.

Additionally, please verify that Time axis type selector and Start/Finish boxes on the Setting stab are working properly and handling invalid input, as I've re-factored their code a bit.

Last edited 7 years ago by Arturs Bekasovs (previous) (diff)

comment:10 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:12 Changed 7 years ago by Roman Tolchenov

Working fine.

comment:13 Changed 7 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/bugfix/8855_muon_guess_alpha_exception'

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/MuonAnalysis.cpp

Re #8855

Changeset: 11a7fdbbbd66fc7ede8899acb44c838fef697bc6

comment:14 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8855_muon_guess_alpha_exception'

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/MuonAnalysis.cpp

Re #8855

Full changeset: 11a7fdbbbd66fc7ede8899acb44c838fef697bc6

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9699

Note: See TracTickets for help on using tickets.