Ticket #8857 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Masking with new IDF breaks BASIS reduction

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: blocker Milestone: Release 3.1
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

The new IDF for BASIS breaks reduction for the old files when a current mask is in place.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to inprogress
  • type changed from enhancement to defect

comment:2 Changed 7 years ago by Michael Reuter

Refs #8857. Fixing masking issue.

Changeset: f9e89fc6dcde8cc4d508dd4c7f72d582e52ea146

comment:3 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found ​here.

To test: Use the BASISReduction algorithm on run 21403 using the default mask and -120,0.4,120 for the energy bins and 0.2,0.2,2 for the momentum transfer bins. The reduction should run to completion without crashing. Also try running 23741 to ensure a newer run is not broken as well.

comment:4 Changed 7 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:5 Changed 7 years ago by Stuart Campbell

Both runs complete with no errors.

comment:6 Changed 7 years ago by Stuart Campbell

  • Status changed from verifying to closed

Merge remote branch 'origin/bugfix/8857_basisreduction_mask_issue'

Full changeset: ​1a01b30a53a1d337a8f99788105b1a8475861716

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9701

Note: See TracTickets for help on using tickets.